Shortcodes should return their HTML, not output it. You need to reorgenize your shorcode code to do that.
You get some correct output just by luck now, if you were testing with actual content you would have seen that your code outputs at the wrong place.