why shouldn’t i save metadata when its a revision

You omitted how is this function called. I assume it is added to save_post action.

This action passes current post id as argument. In case of revision that would be revision id and not parent post id. So, as I see it, there is no reason to save additional data for revision (creating duplicate set of it).

Update.

Scratch that.

I looked through source code. Apparently *_post_meta functions will automatically change to parent post id if passed revision post id. So you might modify original post, thinking you are modifying revision.

Related Posts:

  1. ‘Global’ settings page for multisite plugin
  2. What Are Security Best Practices for WordPress Plugins and Themes? [closed]
  3. How do I show data from gravity forms in my template? [closed]
  4. How can I add a featured image to a page?
  5. How to customize a plugin whilst maintaining ability to upgrade
  6. PHP code on Visual Composer Plugin
  7. How are plugins in the WordPress plugin directory ranked?
  8. How can I log a user out of WordPress before the page loads?
  9. What does a security risk in a plugin look like?
  10. How to generate/update a XML sitemap without plugins?
  11. How to assign user a role if none is present when logging in
  12. update_meta_user difference in i:1 and b:1, how to write b:1
  13. Registration Form Validation in wordpress
  14. Migrating a File from Plugin to Theme and changing its path → instead create a REST endpoint
  15. Access wordpress functions inside a plugin class
  16. resize only height using wp_get_image_editor
  17. View the source code of a 3rd party plugin? [closed]
  18. How to find out what blocks are added by a plugin
  19. Can’t access my WP dashboard: fatal error? [closed]
  20. allow arabic letters when register new account
  21. Use plugin or custom post type for game score functionality
  22. How can I see the error generated by plugin activation?
  23. Cannot access wp-admin after disabling all plugin
  24. What is Stable Tag in WordPress plugin readme file
  25. Next and/or previous post content
  26. How To Clean The Malware Infected & Hacked WordPress Websites? [duplicate]
  27. How to remove style and js from theme and add your own style and js where shortcode is used?
  28. How to periodically scrape and cache strings from remote txt files. – My First Plugin
  29. Re-naming a theme/child theme whilst maintaining updates
  30. Get posts from WP_Query and format them on admin_head
  31. Redux Framework has an embedded demo. Click here to activate the sample config file
  32. Pull out Advanced Custom Fields in Related post plugin
  33. Can’t Update or Delete Plugins From WordPress
  34. Set and access global variable
  35. Is there a way to test that readme looks in other language before submitting translation?
  36. Insert content of a post into another
  37. ob_start() combined with wp_query
  38. Theme/Plugin installation through url on button click
  39. w3 Total Cache not Caching – Requested URI is rejected [closed]
  40. Which file of wordpress manage plugins functionalities?
  41. Can I put in Github the code of a abandoned plugin I want to fork?
  42. How to use login_redirect with a user capability
  43. I should enable automatic updates?
  44. Form that generates an ID for the customer
  45. Access a particular field in an array
  46. Passing stored variables to add_filter
  47. plugin shortcode not working on ajax request call
  48. Ajax Plugin Not Echoing Response
  49. Different custom templates for product category [closed]
  50. How to check wp_options’s rewrite_rules if current and existing are the same before flush the rules?
  51. is_rtl returns false while it should return true
  52. How to create wordpress page that lets users create their own quiz? [closed]
  53. Can i legally remove a credit from a free plugin on wordpress.org? [closed]
  54. How to reinstate previously saved option?
  55. WordPress database error You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version [closed]
  56. Woocommerce product info in a sidebar?
  57. Localise settings section headline
  58. Google Appointments in WordPress?
  59. wp_options not returning value for logged out users?
  60. Gutenberg default attributes are empty when accessing in edit
  61. how to create a custom page in child theme or plugin?
  62. How to add custom plugin data to the cart in woocommerce using custom button on product page?
  63. Warning: call_user_func_array() expects parameter 1 to be a valid callback, function
  64. Hide all Admin Notices and move on a separate page
  65. Front Page of Site Has Gone Replaced By Random Page
  66. Genesis Child Theme – Customize body
  67. Creating categories while importing via CSV
  68. Multiple wordpress installations with same plugin folder (Apache Virtualhost)
  69. How can I show login popup when user clicks on download button
  70. Website content not displayed anymore after updates
  71. Flexslider empty slide
  72. WordPress plugin changes not updating
  73. Adding javascript to header of MetroMagazine theme
  74. How to Save settings of custom tab product page in admin side in a database?
  75. Issue: CSV file upload works only when “View page source” is done
  76. Meta box: Undefined index
  77. How to update plugins in a distributed wordpress scenario?
  78. galleria for WordPress not working properly on Mobile devices (responsive)?
  79. Get plugin versions in xml/json format
  80. Shortcode registered from a plugin not recognized
  81. Make a wordpress site similar to Hot Or Not – Image rating system [closed]
  82. How to submit readme.txt file in wordpress directory
  83. wordpress shortcode A executing code from shortcode B
  84. Plugin for Reading Documents, PDF’s etc
  85. Simple Data Table Update and Page Integration
  86. How to create plugin list groups?
  87. Show latest and related articles from 3 different blogs
  88. Woocommerce custom fields
  89. This plugin throws error on the events page only [closed]
  90. WordPress Code Access to Restricted Content without Registration
  91. How to pre-set WordPress settings for specific posts?
  92. Two sites one PC
  93. PHP if url extension action=discussion condition use [closed]
  94. Is it possible to set different payment gateway on each Gravity Forms form? [closed]
  95. How to get URL param for pagination in shortcode?
  96. How to add an active state class to my info box
  97. Using ACF to allow user to add and edit multiple saved forms
  98. Difficult case to solve – Select + select = result(related data)
  99. How to disable display all posts from all categories?
  100. Custom Login and Password Reset for BuddyPress Website