Right way to download file from source to destination

There is no need to use the WP filesystem API if you are trying to access directories to which the web server has full access. It is needed mainly only when you want to write to directories which have limited access like the plugin directory. From that point of view the two snippets are the same.

What you are potentially doing wrong is trying to access a remote resource with file API. Your first snippet will fail on some hosts and I am totally not sure if the WP filesystem API will work.
A more robust way is to use the wordpress HTTP to get the content of the file with wp_remote_get and save it to the uploads folders.

… last thing don’t do copyright infringements, too many people payed too much for such things.

Related Posts:

  1. Setting wp_temp_dir and permissions not working for “Missing A Temporary Folder” error
  2. Which filters or actions to use after a media upload and delete?
  3. Allowing all/different file type uploads
  4. Use WP_Filesystem to list files in directory
  5. wp_temp_dir does not change the /tmp temporary default directory
  6. Where is Featured Image code stored in WP?
  7. how to change max file upload size WordPress 4.9.8 [closed]
  8. Can’t write pdf file to upload directory using FPDF
  9. Change default uploads file using wp Skeleton
  10. Adding Adobe files to a wordpress site [closed]
  11. Placing assets for external use
  12. WordPress HTTP Error on File upload
  13. Interface for logged-in users to upload/download files
  14. WordPress Creates Unused (Unregistered) Image Sizes
  15. What functions of WP_Filesystem allow me to create a file with code-generated contents in a directory?
  16. Upload PDF and other files from the Front-End
  17. Uploaded images result in a file url with full path on disk appended
  18. temphangle variable missing when using wp_filesystem copy
  19. Where to store sensitive uploaded file?
  20. How to upload .tex files in wordpress?
  21. Downloadable content file structure
  22. Creating an .ics calendar subscription service with wordpress
  23. Should I use Filesystem API for reading files or listing directories?
  24. Private file system for attachments
  25. SFTP File Upload Failure
  26. Plupload Intergration in a meta-box?
  27. Trigger refresh for new media manager in 3.5
  28. Physical organization of wordpress media library (Real Media Library plugin)
  29. Can I upload media to a specific folder?
  30. wp_upload_dir how to get just the directory name .
  31. How to generate thumbnails when needed only?
  32. Limit image upload to one and disable audio, video and other document file types to upload
  33. How to add new tab to media upload manager with custom set of images?
  34. No Thumbnails Generated
  35. Media files exist in upload folder but not showing up
  36. How to Require a Minimum Image Dimension for Uploading?
  37. How to upload files straight to S3 without using local storage? [closed]
  38. Extend Media Library
  39. How does WP media uploader create the 3 different sized images, and how can I duplicate it
  40. How to make “Upload files”selected by default in Insert Media?
  41. WordPress 3.5: Setting custom “full URL path to files” in the Media Library?
  42. Get $image_id after uploading with media_sideload_image()
  43. simple solution for restricting access to (some) uploads/downloads
  44. what happens to existing media files when I switch to year/month directory structure format?
  45. Reject upload of wrong-sized images using the Media Uploader
  46. WordPress Media Uploader events
  47. Creating directory in uploads – wp_mkdir_p() or WP_Filesystem?
  48. How to show all available images in WP’s media library when using the Polylang plugin?
  49. how to upload and allow downloads of .mobi and .epub formats
  50. Standard location for plugin to save/cache files?
  51. Upload post thumbnail from the front end
  52. Allowing WebP uploads?
  53. Give users a maximum upload capacity; limit the number of files a user can upload OR limit the number of files per upload
  54. How to add a custom field to the media screen (image/gallery)?
  55. Can’t upload media, permissions are correct
  56. How to assign multiple file-mime-types to extension?
  57. Saving Media – Which Hook is Fired?
  58. Set limit to media upload?
  59. Is it possible to reorganize the WordPress uploads directory?
  60. WordPress 3.5: Switch back to Old Media Uploader?
  61. Save camera info as metadata on image upload?
  62. Media upload finished hook
  63. Users can’t upload images on frontend if they haven’t got access to the wp backend
  64. How to upload SVG in WordPress 4.9.8?
  65. How Can I Organize the Uploads Folder by Slug (or ID, or FileType, or Author)?
  66. How can I batch delete all unattached images with WP-CLI or other automated process?
  67. Create image formats with different qualities when uploading
  68. Rename files during upload using variables
  69. upload_async.php returns 500 error
  70. Organize uploads by year, month and day
  71. wp_delete_attachment doesn’t delete images in wp-content/uploads/
  72. Display attachments by ID in a wp.media frame
  73. Force WordPress 3.3 to use Flash uploader
  74. Use a separate custom table (not posts) to handle file upload data
  75. Upload folder is not writable, even when permissions are correct
  76. Different upload directory based on post type in a theme
  77. Media not actually deleted on disk when click “Permanent Delete”
  78. Image upload callback in new 3.5 media
  79. retrieve custom image sizes from media uploader javascript object
  80. Add inline uploader to plugin option page
  81. Protecting direct access to PDF and ZIP unless user logged in (without plugin)
  82. How to wp_upload_bits() to a sub-folder?
  83. Using same directory for storing all uploaded images on a WordPress network
  84. Insert images to post not working
  85. Is it possible to allow zip files to be uploaded in WordPress?
  86. How to restrict images in v3.5 Media Library modal to only those from a specific post id?
  87. Allow CSV files to be uploaded
  88. Contact Form 7 – process form using a PHP script, instead of mailing [closed]
  89. Get an uploaded attachments local server path?
  90. How to add more upload directories?
  91. Change WordPress upload path and URL
  92. Could a large quantity of files in the uploads folder affect performance?
  93. PNG with transparent background turns black when uploaded and resized
  94. “Add Media” only shows “Full Size” under Attachment Display Settings
  95. Differentiate Featured Image from Post Images upon Upload
  96. WP 3.3 > Still no option to enable automatic image overwrites?
  97. Where do the favicons for Media Files come from
  98. How are the year and month folders added to the uploads directory?
  99. Where does wordpress store the FTP credentials?
  100. WP 3.5 media manager – how to create a working gallery frame
Hata!: SQLSTATE[HY000] [1045] Access denied for user 'divattrend_liink'@'localhost' (using password: YES)