footer menu changes primary menu

Your argument is wrong. It is theme_location not theme-location. The underscore matters.

Also, what you are doing with esc_html__() is overly complicated. You aren’t passing HTML through the function, and I am fairly sure you never should pass HTML for this, just a string. All you need is __()