get_post_permalink() and custom permalink rewriting

The problem must be how you define your post variable. You assume it’s the global $post but that’s not always the case especially in non-singular pages like archives.

The filter itself provides the correct post instance that’s it’s been called on as 2nd parameter.

function product_type_permalink( $post_link, $post ) {

     // current post is already defined.
...
}

Also don’t get confused by the fact your code is in functions.php. It gets loaded on every WP page load, incl. in admin.

Related Posts:

  1. How to rewrite URI of custom post type?
  2. How to remove slug from hierarchical custom types in 3.5.2
  3. Custom post types – Use post_id in permalink structure
  4. Custom Post Type and Taxonomy URL rewrite
  5. Custom post type permalink: only use %post_id% and remove %postname%
  6. Rewrite custom post type rss feed links
  7. Is it possible to change the URL of custom post types to hide the post type slug?
  8. Archive page with multiple taxonomies rewrite
  9. rewrite get parameter with custom post type
  10. Taxonomy page returns 404 page not found
  11. Remove unwanted part of permalink custom structure from CPT url?
  12. How to have a custom URL structure for a custom post type?
  13. Display CPT taxonomies as an archive page
  14. Including two taxonomies in a permalink structure
  15. WP Rewrite Rules – Custom post type & taxonomy
  16. Changing a custom post type “has_archive” after registered
  17. URL Design for Sub-Posts?
  18. Remove base slug in CPT & CT, use CT in permalink
  19. How do I list terms of a custom taxonomy at i.e. domain.com/brands/
  20. Permalink Structure problem with cpt and custom taxonomy
  21. Custom Taxonomy 404
  22. Custom Post Type rewrite redirects to homepage
  23. Custom Post Type slug same as page name causing a conflict
  24. single-{post_type}.php is not loaded despite flushing rules
  25. Adding paged query to custom URL rewrite
  26. Custom Post Type rewrite rules not working, how to alter the rewrite order?
  27. Custom Permalink for Taxonimie and Custom Post Type
  28. Rewrite Custom Post Type URL slug
  29. Rewrite numeric ID parameter for hierarchical custom post type
  30. Customising rewrite rules for CPT single post URL to work as paged URL
  31. Remove custom post type slug not working for child pages
  32. Custom WP TItle from custom template with dynamic URL structure
  33. Rewrite rules for custom post type slug
  34. In WordPress how do you create a custom post type with the author’s name in the slug?
  35. Change URL of posts and also Custom Post Type
  36. Custom Post Type rewrite
  37. How can I display an archive of only one category of my custom post type?
  38. Permalink Structure CPT With Custom Taxonomy Fails
  39. Conditionally custom post type url rewrite
  40. Making a custom help center page
  41. Get Taxonomy Term Title by it’s URL
  42. Can’t get custom rewrite tag, query var, permastruct (permalink structure), and rewrite rule to work properly together
  43. How to create custom url structure based on custom post type rewrite slug, taxonomy and category slug?
  44. WordPress custom post type permalink rewrite shows page not found
  45. Using taxonomy term in CPT permalink – Pages 404’s
  46. Customize Custom Post Type URL
  47. Programmatically rewriting slug through functions.php but returns 404
  48. Custom Permalinks with CPT and Hierarchical Taxonomies
  49. Why isn’t my custom post type archive URL translating?
  50. Custom Post Type and Category Base Rewrite Issue
  51. Rewrite URL of Custom Post Type for Jobs
  52. Post Type rewrite rule to point to custom Page/template
  53. Custom Permalink Structure for Custom Post Type, Custom Taxonomy, Under a page
  54. Specific routing for CPT
  55. Lost of query parameter when using permalink
  56. Custom permalink with child taxonomy terms
  57. Custom post type archive with page as parent url
  58. Pagination custom post type not working with rewrite slug
  59. Custom Rewrite Rule for Custom Post Type with URL Param
  60. WordPress custom slug rewrite
  61. WordPress Custom Post Type – Rewrite Query
  62. After creating Custom post type by user delete old one
  63. Set parent for custom post type archive rewrite url
  64. Dynamic CPT permalink structure based on ACF field value
  65. URL Rewrite – Page Archive
  66. Urls in Custom Post Type work for Terms but not for its Taxonomies
  67. Custom Post Types and Removing Slugs – should we do it?
  68. Taxonomy rewrite pagination 404
  69. custom post archive URL is wrong
  70. WordPress is ignoring my post rewrite rule
  71. Remove cpt slug from url and use custom taxonomy instead breaks all other cpt
  72. Custom Permalink For Custom Post Type – Working Fine But Broken For Pagination
  73. Duplicate content problems after adding an archive page to the article’s post type
  74. How to properly set the rewrite rules for this case?
  75. Redirect Custom Post Type from Child Taxonomies
  76. Custom post type structure + permalink structure
  77. Rewrite URL of Specific Post of Custom Type
  78. Using get_post_type with a custom URL format?
  79. Custom post type rewrite and wp_pagenavi interfering with each other
  80. Show index and not the archive for “Dog Custom Post” with default slug
  81. Custom Post Type rewrite url to /category/pagetitle [duplicate]
  82. Paging not working for hierarchical custom post type
  83. redirect old post type url to new structure url
  84. Custom Post Type URL Rewriting
  85. Archive page for a custom post type using WPML
  86. Why is a custom post type’s URL “/?cposts=name-of-the-post” but default post’s URL is “/?p=ID”?
  87. Customize category URL
  88. rewrite rules add a folder in the path
  89. How can you preserve URLs when moving posts to a custom post type?
  90. Custom Post Type Base URL
  91. Custom Taxonomy in Permalink from post type
  92. Custom Post Type and single-posttype template
  93. How to rewrite custom slugs that follow my rules
  94. Custom post type with custom taxonomies structure url not working archive of CPT
  95. What is the best way to relate different custom post types?
  96. Allow child pages with the same base as the CPT slug
  97. How to work with URLs where sometimes a post or a subcategory is in the same part of the URL structure
  98. How to make 2 (or more) custom post type post pages sit under the same slug?
  99. Remove date rewrite rule for custom post type archive page
  100. Display content based on multiple URL parameters—pretty URL or query string