Merge two search functions for custom post type

Your functions are already simple enough, and secondly, the functions do different things:

  • _s_staff_query() filters the posts query variables and the function has to run before WP_Query queries the database.

  • _s_staff_search() filters the search results template and the function has to run after WP_Query queries the database.

So just keep them independent.

Related Posts:

  1. ajax category filter
  2. WordPress 4.9.5 PHP intermittent warning trim() expects parameter 1 to be string, array given
  3. Pagination custom query
  4. Order by two meta keys
  5. Finding all results from database within 500 miles of the given latitude and longitude [closed]
  6. Function to check if author has posted within the last x days
  7. Shortcode returns escaped HTML tags
  8. Calling a custom excerpt function in a local loop
  9. How to get any tag ID
  10. Dynamically Override Fancy Title – Part II
  11. query posts in functions.php and update a field
  12. Get posts using WP_Query
  13. Finding post content that begins with a specific character
  14. Best practice custom function, where to echo the variables?
  15. How to get user_id from wordpress database inside ajax function?
  16. posts_per_page not working
  17. Exclude admin from WP_Query Contributors
  18. Multiple Loops Inside a Function
  19. How to delete taxonomy term when a wordpress user is removed?
  20. Exclude category for main query and custom
  21. Display posts from only one post form in custom query and exclude in main query
  22. Category applied to pages, creates multiple breadcrumb entries after a search query (On the translated site)
  23. How to filter, restrict and return posts based on custom user meta information
  24. WP Query using tax_query & meta_query
  25. wordpress search word, “hello world” ===> ‘hello+world’ ===> ‘hello’, ‘world’
  26. Display most popular in the past two days
  27. meta_query not working as expected
  28. New WP_Query calls Pre_get_posts filter twice
  29. how to access query string in wordpress?
  30. Make a SQL query with wpdb in WordPress
  31. how to use pre_gets_posts to exclude one queried ID from homepage loop
  32. Error with function in functions.php?
  33. Exclude authors IDs from WP_Query
  34. Loading two different AJAX requests on two different pages
  35. Getting the post terms ‘wp_get_post_terms’ per post when within the functions.php file
  36. How to load a script code only in posts?
  37. Multiple meta_key ordering with pre_get_posts
  38. How do I fit WP_Query arguments into a function?
  39. Create a notification for post field
  40. Add URL Rewrite Rule To WordPress
  41. Trying to get property of non-object in: $wp_query
  42. WordPress dynamic AJAX query
  43. relation OR instead of AND – Filtered term ID’s in loop
  44. Pagination repeating posts on search results
  45. How to check if logged in user have pending custom post?
  46. Custom WordPress post query for displaying time-released content on website
  47. SEARCH QUERY PLEASE HELP | call_user_func_array() expects parameter 1 to be a valid callback php
  48. Custom query for custom post type not getting correct post ID
  49. Finding post ID dynamically on click
  50. how to move a page from one drop down menu to another drop down menu
  51. How to upload 3 attachments to current post?
  52. Global page ID variable empty error
  53. WP_Query & shortcode : Return 3 articles from a category WordPress
  54. Get post Number with local loop and template
  55. Save query in function for custom gallery
  56. Seach and categories not working when ignoring sticky posts in main loop
  57. Problem with custom WP_Query and underlying pagination/posts_per_page
  58. Calling a function with WP_Query only ever brings the first result
  59. What argument does my function need to echo get_results() query results
  60. Fetching $_POST from Page Template into functions.php
  61. Declare inline background image in functions.php
  62. I wan to process the following js to process the AJAX Request on my function to calculate author Total Post views
  63. Hiding all posts/products/pages from a site based on a custom taxonomy/domain name
  64. ordering and optimizing functions
  65. Why WP_Query in functions.php is not working when get_posts works?
  66. Adding css tweak based on page template
  67. WP_Query and DES sort for Custom Taxonomy based upon a meta field?
  68. How to write a query-function as a query-shortcode?
  69. 1500+ duplicate queries via get_option function (query monitor)
  70. Variations as Single Products [closed]
  71. Excluding a category from frontpage but not from WP_Query
  72. WP_Query by post ID doesn’t work if post is in custom post_status
  73. Tracing the life of a query
  74. WP_Query orderby taxonomy term value (numeric)
  75. WP_Query compare with dynamic values
  76. Programmatically set ‘meta_query’ for filter
  77. WP Query Exclude and Start by Menu Order Offset
  78. WP_Query Excluding pages with Order is 0
  79. Show all post for a given category
  80. WP_Query create html structure
  81. Change post order random through out the entire WordPress
  82. Can I simplify in function column_default use of queries
  83. How to provide meta_key array to wp_query?
  84. Specify strict ‘order by’ in WordPress query
  85. wordpress udpate query not equal to
  86. How to generate feed for custom template
  87. WP_Query with one category in args shows other categories
  88. Excluded category from loop
  89. Add content depending on page loaded
  90. WP Query and multiple pages
  91. meta_query with meta values as serialize arrays
  92. Multiple WP_Query args combinations according to post type
  93. wp_set_object_terms() custom taxonomy not working correctly when using insert post
  94. wp_query returns match with no criteria
  95. pre_get_posts with WP_Query to prevent posts from specific tags
  96. Different number of posts showing in development vs production server
  97. Order WP_Query results in order other than ASC or DESC
  98. Get post closest to today
  99. Pagination in custom query not working [duplicate]
  100. $query_args for loop to only get posts from “current category”?
error code: 523