URL to Post Meta [closed]

The code you posted:

 <a href="https://wordpress.stackexchange.com/questions/270167/<?php
    if ( is_user_logged_in() ) {
        echo get_post_meta($post_id,"external_link', true);
    } 
    else {
        echo 'Login to View';
    }
   ?>
 ">View Website</a>

Is going to echo “Login to View” as the href attribute.

You need something more like:

    <a href="https://wordpress.stackexchange.com/questions/270167/<?php
        if ( is_user_logged_in() ) {
           echo get_post_meta($post_id,"external_link', true);
        } 
       else {
          echo wp_login_url( get_permalink() );
}
?>">View Website</a>

That of course won’t be changing the text, just the href. So maybe do the conditional a step earlier (I added an arbitrary <span> for context):

<span> 
<?php 
if ( is_user_logged_in() ) {
   $href = esc_url( get_post_meta($post_id, 'external_link', true ) );
   $text="View Website"; 
}
else {
    $href = wp_login_url( get_permalink() );
    $text="Login to View";
}
?>
<a href="https://wordpress.stackexchange.com/questions/270167/<?php echo $href; ?>" ><?php echo $text; ?></a>
</span>

Since you’re pulling the url from the db, I wrapped it in esc_url() for sanitization.

Related Posts:

  1. How do I retrieve the slug of the current page?
  2. Most efficient way to get posts with postmeta
  3. How to extract data from a post meta serialized array?
  4. How to save an array with one metakey in postmeta?
  5. WordPress is stripping escape backslashes from JSON strings in post_meta
  6. How to update_post_meta value as array
  7. What’s the point of get_post_meta’s $single param?
  8. Lack of composite indexes for meta tables
  9. Get a single post by a unique meta value
  10. Content hooks vs User hooks
  11. Save both current and new version of post meta
  12. get_post_meta – get a single value
  13. delete value 0 in post meta [closed]
  14. Can I safely delete a record, manually, in the wp postmeta table?
  15. get_post_meta / update_post_meta array
  16. Exclude a category from the filed under list
  17. Triple meta_key on custom SELECT query
  18. update_post_meta not adding anything.(Nor add_post_meta)
  19. Identifying Importer Posts
  20. Add a post metadata if only the key and value does not exist
  21. How metadata API works?
  22. How can I get values using key in Carbon Fields from Multiselect?
  23. How to sanitize post meta field value?
  24. Post IDs missing on delete_postmeta action hook
  25. How trigger to save post when updating post meta
  26. Create a Metabox that behaves Like a Taxonomy Box
  27. Views count with time limit per IP
  28. Get page->parent’s name?
  29. order by multiple meta_keys?
  30. conditional function to change post-meta background image
  31. how to get all post with the same post meta?
  32. echo image caption
  33. get_*_meta doesn’t always return an array
  34. Generate multiple goo.gl shortlinks for qtranslate bilingual blog
  35. How to programmatically customise the Contact Form7 notification email prior to sending? [closed]
  36. How can I convert postmeta from unserialized to serialized?
  37. Saving repeated option values when querying in Published, draft and all
  38. add_post_meta adds meta to one more different post
  39. get_post_meta() not work for the first post inside the loop
  40. Custom query, multiple custom keys
  41. Trying to get property of non-object error using get_post_meta()
  42. How can I change the tag contents of individual WordPress posts?
  43. get_post_meta producing white screen of death
  44. update_post_meta not working in plugin
  45. Gutenberg: How to display meta field data in the block frontend (save function)
  46. Look up all posts by status or meta value – performance difference
  47. String taken from database table post_meta is showing HTML tags on Frontend
  48. Can A Post Meta Field Store multiple values that are not in an array?
  49. esc_attr on get_post_meta [closed]
  50. Sort custom posts in archive by multiple values: date AND meta key
  51. Delete posts based on post meta data
  52. How is the author’s name given a different color?
  53. How does WordPress treats attachments metadata in post content?
  54. How do I edit the posted “by” and “on” in the post meta
  55. How to delete duplicate records in wp_postmeta database table?
  56. update_post_meta() adding bits in database [closed]
  57. add_post_meta doesn’t work
  58. Get posts ordered by meta data
  59. Displaying values from related field – if empty shows current post type’s link and title
  60. get_post_meta inside echo [closed]
  61. WordPress postmeta: Store data as an array or single item?
  62. Display Post Meta in Header
  63. get_template_part() isn’t loading author information
  64. Array of user ids to list of user names
  65. Conditional For get_the_author_meta
  66. Custom fields or something else
  67. get Insert id for meta field
  68. Is there a way combine posts meta_name?
  69. Format meta_value [closed]
  70. I want to Add Feedburner Right After Meta Details
  71. if get_post_meta function returns empty – Do Not Display HTML
  72. Custom column on CPT not showing correct value when meta data not set
  73. How to access post meta on the first time a post is published
  74. Removing Malware
  75. I Can’t get the post_tag name from term_id using wp_set_object_terms
  76. After updating the custom post type, metafields disappear from the post.php edit menu, how do I fix it?
  77. How to update/add child posts meta whenever the parent post meta is updated?
  78. How to query post with meta?
  79. why is my postmeta table is so heavy
  80. update_post_meta() throws Uncaught error: Cannot create duplicate attribute
  81. Using a comma instead of a pipe to separate metadata
  82. show user based on user_meta
  83. Multiple meta key and value search in the query
  84. Meta keys won’t add using wp_insert_post
  85. How Can I extract Image urls from post meta
  86. Assign postmeta in bulk
  87. Twenty Twelve entry meta data – change and move
  88. Re-order posts inside tax query
  89. How can I prevent the post_modified column in wp_posts from being updated?
  90. Sorting meta box values by start- and enddate and all dates in between
  91. Use an id on a button to update_post_meta in post
  92. Using mysql queries to delete custom post types based on meta_value
  93. get_post_meta image width for lazy load
  94. Custom Fields help
  95. WP-API : post_meta not updated… but have another entry
  96. Parse error thrown by get_post_meta [closed]
  97. How to get all the related ids without array?
  98. Remove action of an external plugin after checking if custom post meta is set
  99. I am stuck between post meta function to call unique id
  100. Post meta box data not saving
techhipbettruvabetnorabahisbahis forumutaraftarium24edueduseduedusedueduedueduedusedu