Extracting the post_id via the wp_insert_post action (external db query)

You shouldn’t be calling get_the_ID() outside of a post loop, and the post ID is handed to you using the filter as a function argument:

function insert_new_table( $post_id ){

So use $post_id

Added notes

  • Don’t use mysql_connect etc that extension was deprecated and is no longer included by default in newer versions of PHP. This code will fail on PHP 5.5+, if you must abandon the WP APIs use PDO or Mysqli
  • You don’t have to use the global wpdb object, you can create your own: $mydb = new wpdb( $dbuser, $dbpassword, $dbname, $dbhost );
  • You’re creating a table for each post in a remote database with a name and an ID column, this is wasteful and bad table design. Would it not make more sense to have a single table containing all names with a post ID in it? Why must it be in a separate database? What happens if your IDs change? Why not use custom post types/post meta/custom taxonomies? You realise there’ll be a significant latency cost if your database is located elsewhere? Your data will not survive a site move or import/export
  • Pick an indenting method and stick to it, your editor should be capable of automatically fixing and indenting without any effort from you, if it doesn’t you should find a new one. I would recommend sublimetext or PHPStorm but others exist. WordPress standards use tabbed indenting taking up 4 spaces on the screen. PSR standards use 4 space characters.
  • You’re not checking for drafts and revisions

Related Posts:

  1. Using wpdb to connect to a separate database
  2. WPDB Insert or if exists Update
  3. get_results using wpdb
  4. $wpdb won’t insert NULL into table column
  5. Get error messages when $wpdb->insert() returns false?
  6. Does dbDelta delete columns as well?
  7. How to fetch Data in WordPress using MySQLi or $wpdb
  8. wpdb->insert multiple record at once
  9. WordPress Unit Testing – Cannot Create Tables
  10. How to define composite keys with dbDelta()
  11. Does wpdb add considerable overhead on queries with large result sets?
  12. $wpdb->prepare() warning in WordPress 3.5
  13. Hook into $wpdb
  14. Display data from a non wordpress database on a page template
  15. How does $wpdb handle COUNT(*)
  16. WordPress database error: [Query was empty] [closed]
  17. Actions or filters fired when data is saved in a custom table
  18. Inserting Post Meta From SQL
  19. Connecting to external oracle database
  20. Can’t save ajax value to database
  21. $wpdb variable throw this error Call to a member function get_results() on a non-object in
  22. Updating all rows of table with $wpdb
  23. How to execute mulitple statement SQL queries using $wpdb->query?
  24. Is $wpdb->prepare escaping to much? How to use it properly?
  25. When and why should I use $wpdb different return types?
  26. How wordpress accesses its own database
  27. Remove database entries where post_date > expiration date
  28. Error connecting to DB in /wp-includes/wp-db.php on line 1538 [closed]
  29. How to query the WordPress database to get posts of a certain custom post type, taxonomy and field?
  30. Get data from database using $WPDB
  31. How to use a different database to list and manage comments in the backend
  32. Getting all the users who have author privilege
  33. Cannot update custom database table row
  34. wpdb_prepare with multiple or condition
  35. Show last modified date of database
  36. $wpdb->insert is not working
  37. In what part of the WordPress core does the users table and usermeta table get joined?
  38. Advanced SELECT query with condtional statements
  39. WordPress choose wrong database
  40. wp_get_current_user always returns 0 continued
  41. Redirecting to old domain after migration website
  42. Create table from array with prepare
  43. Update from 4.5 to 4.6 failing
  44. Does WordPress $wpdb functions wait when table is locked?
  45. How Can I Put Meta_Compare in the Database-Query?
  46. $wpdb->insert Giving duplicates
  47. I’m not able to get access to $wpdb [duplicate]
  48. Have working sql query… trying to adjust it to use $wpdb
  49. Problem in using wpdb
  50. $wpdb->query can’t insert data
  51. How to fetch records from database WordPress
  52. Best practice to import user base (subscribers) from one website to another?
  53. AJAX wp-mysql running too slow
  54. Problem migrating to localhost
  55. Clear Terms from Taxonomy for Specific Post IDs?
  56. Connecting to a different database
  57. Query Column of Specific ID from Database Table
  58. How to delete a particular row in a database table
  59. How to create more than one new wpdb object?
  60. Update multiple rows in one query
  61. How to connect and insert data in database of wordpress?
  62. Should I use an additional column in the DB?
  63. access JSON results from wordpress database with wpdb
  64. Getting value from database table depending on field value
  65. add_post_meta — not working
  66. wpdb->insert not inserting first variable
  67. How do I have a user upload a blog post and then retrieve that to display in a card on the site?
  68. How to escape percentage sign(%) in sql query with $wpdb->prepare?
  69. wpdb Insert unknown post data dynamic foreach loop
  70. How do I get database rows from a custom table using wpdb?
  71. Help with $wpdb on custom code
  72. “BS_” rows in postmeta table
  73. $wpdb->insert duplicating rows
  74. How to rerieve comments and their replies from DB
  75. Can I use a wpdb object to connect to a non-WordPress Oracle database [duplicate]
  76. Help posting values to DB on submit using $wpdb->query
  77. How to add download link from database on custom page template?
  78. How to store additional data that is related to core data
  79. 2 $wpdb queries causing error Table ‘wp_postmeta’ is specified twice, both as a target for ‘UPDATE’
  80. insert data from a form:: Warning Empty query mysqli::query()
  81. How can I get $wpdb to show MySQL warnings?
  82. About wp database hooks (error establishing connection)
  83. How to get specific table by current user login
  84. Using $wpdb to insert data into a table
  85. How To connect to the same WordPress database with different database user
  86. Accessing content from third party as native posts in WordPress
  87. Should I Use only wpdb Class to Write Custom Queries?
  88. execute custom function on database connection error
  89. Call to a member function insert()
  90. I have include wp-config, should I add global $wpdb also?
  91. Processing a lot of $wpdb isn’t insert all the data
  92. Can’t Install WordPress (local) Failed to open file wp-includes/wp-db.php
  93. using same mysql user with many databases
  94. Pulling values from a sepcific row in table
  95. Creating Tables in WordPress Database
  96. Inserting into data into external DB using WPDB
  97. Insert Extra fields added in the front end registration form to DB
  98. $wpdb->insert not working for last select option
  99. $wpdb->prepare returns empty array
  100. Uploading to WordPress Database