Get users query makes the site loading time too big?

but this code makes the site loading time too big, and I don’t know
why!

I think that is just because you are getting quite a lot of stuff from the database with your code. Escpecially if your code runs on every single page load.

Here’s my suggestions,

Extra parameters to WP_Query to potentially make the query more efficient.

$args = array(
  'date_query' => array( array( 'after' => '1 week ago' ) ),
  'author' => $userss->ID,
  'post_type' => 'post',
  'numberposts' => -1,
  'cat' => '3',

  'no_found_rows' => true, // "useful when pagination is not needed", from https://10up.github.io/Engineering-Best-Practices/php/
  'fields' => 'ids', // no need for all post data if get_post_meta is only what the post data is used for
  'update_post_term_cache' => false, // not needed if you're not using terms in your loop 
);
$query = new WP_Query( $args );

As a personal experience, I’ve noticed that sometimes it makes sense to write your own sqlstatement and use it with $wpdb->prepare/get_results to get stuff out of the database faster.

Remove wp_reset_query(); from foreach loop

This probably just a minor tweak, but looking at the wp_reset_query Codex entry,

Calling wp_reset_query is not necessary after using WP_Query or
get_posts as these don’t modify the main query object. Instead use
wp_reset_postdata

And I don’t think you don’t need to use wp_reset_postdata() either as you’re not affecting the global $post variable.

Use transient cache

If new contributors and authors are not added very frequently, you could store $user_query->get_results(); into a transient, with sensible expiration time or refresh when new one is added, to skip doing WP_User_Query every single time.

If it fits your setup and situation, perhaps you could save $query = new WP_Query( $args ); for each user as a transient with expiration time of one day. Then update the transient with a cronjob, WP or a real one, daily.

If the view count doesn’t need to be exactly real-time, then perhaps you could consider saving the total result from $counter += $views; into a transient (maybe with a expiration time of one hour?) too.

So instead of querying every time, every post over the last week, for every user with correct role, you would be getting these with three get_transient calls.

Minor tweak to user sorting

I’m not sure, if this has any real effect on the performance, but I’m adding this at least as a curiosity.

// Instead of this
$topuser[] = array( 
  'id' => $userss->ID, 
  'viewz' => $counter
);

// You could do this
$topuser[$userss->ID] = $counter:

// So you can then use arsort() which
// sorts an associative array in descending order, according to the value:
arsort($topuser);

// Create also a helper array to go along with $topuser
$users_by_id[$userss->ID] = $userss;
// From which you can get user data with ID in your foreach ($output as $user) loop

Related Posts:

  1. SQL User Query by Multiple Roles using PHP
  2. How to display user order by role
  3. Set “editor” role to existing user
  4. Getting all user metadata from user
  5. How to add custom query filters in WP_User_Query
  6. Display posts from Last 24 hours and order them based on most views
  7. Hide posts from users with a specific role
  8. How to order posts by custom WP role?
  9. How to hide post content/meta from everyone except the post author and admin
  10. Filter user list that meta_value is empty
  11. Query wp_usermeta alongside wp_users
  12. WP User Query get all authors with last name starting with specific letter
  13. Sort users by “birthday” using WP_User_Query
  14. How to order posts in wp_query by the user role (2 roles in array)
  15. Hide Administrators From User List except current user (administrator)
  16. Import wp users via one click demo option
  17. Dynamic User Id
  18. How can I query users by custom role?
  19. Why does get_posts only show results for Admins or logged-out users?
  20. Does wp track views for posts?
  21. Prevent author bio page from showing in search results
  22. Get multiple users with meta value in one query and populate WP_User class
  23. Searching for meta_key returns 0 posts
  24. Reduce number of SQL queries inside WP_Query loop to fetch author data
  25. Display if author page is author page of current user
  26. Get user first name from custom endpoint
  27. Show menus to one admin username
  28. Storing an array of objects related to each user
  29. Create one-use post dynamically, add to main query, do not insert post (user profile view)
  30. Link Author URL’s based on a custom field
  31. Query to get last posts from authors of blog
  32. Query pages created by deleted users
  33. Query posts by post type, author and post meta
  34. Random users always showing same 8 users
  35. Meta query orderby meta_value_num sorting by role first
  36. Pre_get_posts only show posts by administrator roles
  37. How to query 5 users in random who have published more than 10 posts
  38. How to query users by post count no less than 10
  39. Merge wp-query and get_users
  40. WP_Query: Query posts only if their access is restricted to logged user’s role
  41. Get all wp_users sort by metakey
  42. Logging search queries for logged-in users
  43. List users by Year of Birth using a foreach loop to dynamically populate years and data
  44. Show subscriber id in loop
  45. Displaying content to search engines but via navigation only for registered users.
  46. Query Users by post count, last 30 days and display each users post count according to post type
  47. Get all user with both meta_value
  48. How to know which editor published a post programmatically?
  49. WordPress get_posts function, 1300 lines long
  50. Disallowing Users of a Custom Role from Deleting or Adding Administrators?
  51. What the user_status column?
  52. Too slow when using both ‘tax_query’ and ‘meta_query’ both in WP_Query
  53. Use of caller_ get_ posts
  54. Pagination custom query
  55. WP_Query and name__in
  56. Order posts by tags count?
  57. Unable to combine “search value” and “tax_query” using WP_Query
  58. How to extend tag and category “Related Posts” query to custom post_type if the first 2 terms have no posts
  59. Interupting the loop with extra divs to display data, and how to get it to work responsively
  60. WP_Query, tax_query and term_meta: How to?
  61. How to pass many ids in post__in?
  62. How to echo data after a WP_Query
  63. How do I run through a WordPress loop called from a filter function?
  64. How do I get the title of a category in a custom loop?
  65. Is it a good idea to improve meta query performance by adding tax query?
  66. WP_Query: Group events by year, sorted DESC; then by date for each year group, sorted ASC
  67. hide custom post types with specific meta key ON admin backend
  68. Orderby listing issue
  69. Current post in AJAX call is always zero
  70. Multiple filter conditions for WP_Query
  71. Get all fields inlcuding “ACF” (Advanced Custom Fields) columns in wp_query
  72. WP_query : Force last posts number over Reading Settings
  73. Order by most used tag
  74. WP Query – posts only by specific user
  75. how can I get seperate the HTML in the_content(); output?
  76. Is wp_reset_postdata always necessary?
  77. wp_query: implicit paging? I get less posts that I should
  78. Query within a foreach within a query (queryception)
  79. WP Query Meta Value – How To Identify Specific, Unique Values?
  80. Displaying pages on an archive page
  81. How I can repeat 2 HTML templates in a WordPress Query?
  82. Loop categories by recent post
  83. List of users with email and role
  84. Meta query with compare by more than 2 fields
  85. How to apply pre_get_posts to a custom query?
  86. meta_query returning excluded result
  87. How to pass the current content of $wp_query to a new page?
  88. WP_Query retuning empty array in rest api
  89. Passing a SQL query to the WP Query
  90. Show child by slug, while knowing parent ID
  91. Custom WordPress post query for displaying time-released content on website
  92. Slow Query with more 100 products
  93. Taxonomy archive, categorised by other taxonomy, not hiding empty taxonomies
  94. Migrating mysqli query to wp_query
  95. Second WP_Query loop shows data from main query
  96. How to show featured post first, then separate loop for other posts
  97. error with $query->have_posts()
  98. Multiple Orderby is not working right
  99. Use value from meta key array for use in WP_Query
  100. WP_Query sort by ACF date field (newest first) with blank dates first
error code: 523