Is dynamic action name building a bad practice?

Usually yes, sometimes no, but in your example, definitely bad practice

You see, instead of putting the name or the post ID in the action name, you should have passed it as a parameter instead. Otherwise there is no way to grab all elementor css file parsing, or no way to work after any arbitrary after imported post. You need to know in advance every possible post ID or name that could turn up, making the action very limited in use.

Examples where it might make sense, are where it’s shorthand for an entire class of objects. This is a rarer situation, but an example would be publish_posts versus publish_book where book is a custom post type.

Note that in those situations, these are additional actions/hooks that are done in addition to not instead of generic hooks.

Related Posts:

  1. remove_action or remove_filter with external classes?
  2. Why does save_post action fire when creating a new post?
  3. Difference between do_action_ref_array() and do_action()
  4. Why is there both a save_post and wp_insert_post action?
  5. When is admin_init Action ran?
  6. Can an action callback prevent the parent from continuing execution?
  7. How do I enqueue a script to run inside the Gutenberg editor?
  8. How can I find out what functions are assigned to actions?
  9. Disable WooCommerce action
  10. How can I remove the WP menu from the admin bar?
  11. add_action customize_register not working
  12. Passing arguments into ‘init’ function
  13. How to use conditional add_action for WordPress
  14. WP Schedule Event – Every Day When First Visitor Comes
  15. How to remove an action that is added inside a class
  16. add action which returns modified value
  17. WordPress admin WP_table_list show incorrectly
  18. How to add a checkbox inside the “Publish post” widget?
  19. What’s the usage of action do_meta_boxes?
  20. How can I invoke an action after a CiviCRM triggering event?
  21. Custom bulk actions in WP 3.7.1
  22. Remove action from a plugin class
  23. Modify query in pre_get_posts action is messing up my nav menu
  24. Exclude trash from save_post
  25. How to check if an action is already fired?
  26. add_action and wp_head not display content in head section
  27. use add_action(‘wp_head’) in a widget
  28. array of objects to do_action, callback gets singular object?
  29. Preventing frontpage to be deleted/moved to trash
  30. Selectively applying action based on role
  31. How to remove a custom action on child theme?
  32. Action hook on only publishing post not on editing or updating
  33. how can I use add_action run another function when publishing new post?
  34. Performance : Duplicating `add_action`
  35. add_action in class and use it in theme
  36. How to track post number on the_loop
  37. Better action hook for creating table than after_switch_theme and switch_theme action hook
  38. Adding the hook ‘vc_before_init’ inside a object
  39. How to apply action the_post to the post that is only being mainly displayed
  40. admin_notices on runtime in function
  41. Using several add_action with parameters inside a class
  42. Action hook load_textdomain $domain variable
  43. publish_post action hook not working
  44. Action hook for editing post
  45. add_action and do_action: multiple calls to same callback?
  46. Gutenberg – Dispatch action or setAttributes() on Post Save/Update action instead of onChange listener
  47. remove_action returns false regardless of priority
  48. Set a custom display_name on user_register?
  49. WordPress action admin_post for non-admin authenticated users – Form submission
  50. Instantiating classes through add_action and saving them to user_meta data [closed]
  51. How to make an action run in the background?
  52. WP cron doesn’t pass through my arguments
  53. how to add submenu item under parent menu item with code
  54. Why does my wp_safe_redirect output the ERR_TOO_MANY_REDIRECTS error?
  55. Re-order Woocommerce single product and echo div around moved & duplicated Woocommerce hooks
  56. Custom Post type forgetting data
  57. Insert custom postmeta when custom post type published
  58. Call do_action class’s function
  59. cannot filter after using pre_get_posts
  60. Create post revision on slug change
  61. Generate payment URL in custom email [closed]
  62. Can’t Get Metabox Data Saved Assistance Needed
  63. missing argument 2 when passing arguments to add_action
  64. is there an update_post_meta action
  65. comment_post callback function: how to run it in the background.
  66. Add new users to “add new user” page on admin’s dashboard
  67. add_action( ‘publish_pelicula’, ‘post_published_notification’, 10, 2 ); does not trigger propperly
  68. Change Post Publish Date to Post Modified Date in All Places
  69. save_post not triggered when a post is updated
  70. Action ‘init’ function doesn’t return variable
  71. add_action to wp_head is added, but not called
  72. Where to place add_action when enqueueing?
  73. Insert Google authorship into WordPress header
  74. add_action before theme setup
  75. How can I get the user that publishes a post?
  76. add_action which contains first argument admin_print_scripts-$page
  77. update_user_meta not updating
  78. How do i know which action / filters are called when i call get_option()
  79. How can I get more out of `$post` in an `add_action` callback?
  80. Add Tag to post after publishing
  81. Remove action not working in child theme
  82. Call to Action Button – Resize Help [closed]
  83. Translate are not working for standard admin
  84. wpdb->insert creates duplicate rows
  85. add_action init breaks site on PHP 7.1
  86. Why is this require statement not working?
  87. Adding add_action function
  88. action future_post returns wrong date
  89. XML Imported Custom Posts
  90. Hook into admin_notices after sending mail
  91. save_post action not firing when save
  92. WooCommerce wp_insert_post action firing on every save
  93. WordPress’ work or execution flow manipulating $wpdb
  94. How to enable/disable a hook with theme options
  95. Add-action in function
  96. Building WP Web App: Creating a Feed for post revisions
  97. Can admin_bar_menu or another action be used to modify the admin bar on the admin side?
  98. What is the first action or filter executed by wordpress?
  99. Using add action for class with construct
  100. Webhook: save_post action fires wp_remote_post twice