‘rewrite_rules_array’ or ‘generate_rewrite_rules’ for adding custom rewrite rules?

This is possibly a matter of opinion, but I would say – neither. If you’re simply adding new rules, use add_rewrite_rule hooked to the init action.