Better use two dedicated methods hooked with add_action() to different actions, or can it be twice the same method?

So there’s 4 factors:

  • Performance (Speed, resource usage)
  • Convenience
  • Code maintainability
  • Learning the API you’re using

If you don’t know the performance of your function then it’s impossible to answer your question, but I would guess that if it doesn’t do or cause any database queries, and it’s not doing operations on lots of data, then it’s probably fast.

It seems like what you’re doing is convenient – you have the code in one place and call it from a couple of places it’s needed.

Even though it’s called from two places, as the code is in one place that’s quite maintainable. If you want to change what it does in future you don’t have two places and need to figure out where to put changes, you just change this one function and you know the effect will happen.

You could do this a different way but it sounds like you’re saying that this would involve a lot more time to learn the interface you’re using (i.e. WP script queueing orders) and this might not have a benefit for you.

So, on balance if it’s a fast function there’s no reason not to do this and it’s not bad design due to maintainability.

Related Posts:

  1. Performance : Duplicating `add_action`
  2. What is the first action or filter executed by wordpress?
  3. Remove parent theme action in child
  4. How to do_action and get a return value?
  5. Remove an action from an external Class
  6. Does the event ‘wp_version_check’ even exist? What is it doing?
  7. How do I enqueue a script to run inside the Gutenberg editor?
  8. Why, Where, and When to use reference pointers in filters/hooks?
  9. add_action customize_register not working
  10. Passing arguments into ‘init’ function
  11. Add a Custom Field in Comment Box AFTER text area BUT BEFORE Send button
  12. Using wp_insert_post and post_update_meta but need to fire save_post afterward
  13. enqueuing React script and hooking its target div fails to load script
  14. How to remove an action that is added inside a class
  15. Having an add_action( ‘user_new_form’,) [closed]
  16. Using auth_redirect returns cannot modify header information
  17. Problem:Save Several Duplicate posts in The Database and then Error nesting level of ‘100’ reached
  18. How to remove an action added by a child theme of Genesis
  19. wp_get_attachment_metadata returns false with add_action() ‘add_attachment’ hook
  20. How to add a checkbox inside the “Publish post” widget?
  21. What’s the usage of action do_meta_boxes?
  22. How can I invoke an action after a CiviCRM triggering event?
  23. Remove action from a plugin class
  24. how can I use add_action with external class which the function contain 2 argument?
  25. remove_action not working with procedural function
  26. Why Should We Use wp_clear_scheduled_hook and What it Does?
  27. Woocommerce Change placement with wrapper
  28. Modify query in pre_get_posts action is messing up my nav menu
  29. Exclude trash from save_post
  30. Which action fire in front-end single post only
  31. Unable to show error message using wp_login action
  32. array of objects to do_action, callback gets singular object?
  33. Selectively applying action based on role
  34. where is the documentation for add_action() parameters?
  35. how can I use add_action run another function when publishing new post?
  36. Call add_action() in function wordpress
  37. How to remove function?
  38. Validate form in functions.php, send errors back to template
  39. What is the callback sent to add_submenu_page() invoked by WordPress?
  40. add_action in class and use it in theme
  41. How to track post number on the_loop
  42. How can I trigger actions manually?
  43. Better action hook for creating table than after_switch_theme and switch_theme action hook
  44. $GLOBALS[‘hook_suffix’] variable empty
  45. publish_post action hook not working
  46. add_action() in switch statement
  47. Problem with get_the_excerpt when using an add_action(‘the_content’) containing script tags
  48. add_action and do_action: multiple calls to same callback?
  49. Gutenberg – Dispatch action or setAttributes() on Post Save/Update action instead of onChange listener
  50. Using Nested add_action()
  51. WordPress action admin_post for non-admin authenticated users – Form submission
  52. Instantiating classes through add_action and saving them to user_meta data [closed]
  53. Are the hooks in the dashboard such as “load-$page_slug$” and “admin-head-$page_slug$” reliable and consistent throughout installs?
  54. how to add submenu item under parent menu item with code
  55. add_action and do_action
  56. How to call a static function in add_action() inside another static function?
  57. Add “add to cart” button in WooCommerce [closed]
  58. Call do_action class’s function
  59. Gravity Forms parameters return 1
  60. cannot filter after using pre_get_posts
  61. Generate payment URL in custom email [closed]
  62. missing argument 2 when passing arguments to add_action
  63. is there an update_post_meta action
  64. comment_post callback function: how to run it in the background.
  65. Add new users to “add new user” page on admin’s dashboard
  66. W3TC manual cache flush does not work
  67. Run a function on all posts
  68. Remove an action added within a class in a WordPress plugin
  69. add_action( ‘publish_pelicula’, ‘post_published_notification’, 10, 2 ); does not trigger propperly
  70. add_action.. will work if function is empty?
  71. save_post not triggered when a post is updated
  72. Action ‘init’ function doesn’t return variable
  73. Trying to write a function in an external php file to manage admin menu visibility
  74. Insert Google authorship into WordPress header
  75. add_action before theme setup
  76. How can I get the user that publishes a post?
  77. add_action which contains first argument admin_print_scripts-$page
  78. How can I get more out of `$post` in an `add_action` callback?
  79. do_action in API call
  80. Add Tag to post after publishing
  81. Remove action not working in child theme
  82. Call to Action Button – Resize Help [closed]
  83. How do I dequeue js/css at the last possible moment?
  84. wpdb->insert creates duplicate rows
  85. Remove action from plugin
  86. Need data from two different actions
  87. Understanding and using did_action() in a conditional statement
  88. Adding a conditional to work on certain pages/page templates to an add_action()
  89. Why is this require statement not working?
  90. Adapting functions from Genesis theme
  91. Adding add_action function
  92. XML Imported Custom Posts
  93. Invoke a function before the action hook
  94. save_post action not firing when save
  95. WooCommerce wp_insert_post action firing on every save
  96. How to enable/disable a hook with theme options
  97. Passing arguments in add_action inside search template
  98. Building WP Web App: Creating a Feed for post revisions
  99. Can admin_bar_menu or another action be used to modify the admin bar on the admin side?
  100. remove an action hook function on a plugin from a theme
error code: 523