Creating a copy constructor for a linked list

You have to be careful with Step 1 and part of Step 2. Step 1 should allocate a new node and use that as the head. In Step 2, the part about next = v.next, unless your intention is to make a shallow copy, is incorrect.

When you copy a container such as a linked list, you probably want a deep copy, so new nodes need to be created and only the data copied over. The next and prior pointers in the nodes of the new list should refer to new nodes you create specifically for that list and not the nodes from the original list. These new nodes would have copies of the corresponding data from the original list, so that the new list can be considered a by value, or deep copy.

Here is a picture depicting the differences between shallow and deep copying:

Notice how in the Deep Copy portion of the diagram, none of the nodes point to nodes in the old list. For more information about the difference between shallow and deep copies, see the Wikipedia article on object copying.

Related Posts:

  1. Writing a LinkedList destructor?
  2. Destructor for a linked List
  3. std::out_of_range error?
  4. Debug assertion failed
  5. C++ Compiler Error C2280 “attempting to reference a deleted function” in Visual Studio 2013 and 2015
  6. member access within null pointer of type ‘struct ListNode’
  7. C++ Templates – LinkedList
  8. Destructor for a doubly-linked list that points to its value
  9. invalid use of template name without an argument list
  10. Array of Linked Lists C++
  11. How to create a dynamic array of integers
  12. Making my own toString() method on c++ struct
  13. Struct Constructor in C++?
  14. What is meant with “const” at end of function declaration? [duplicate]
  15. What’s the C++ version of Java’s ArrayList
  16. What is the difference between “long”, “long long”, “long int”, and “long long int” in C++?
  17. ‘g++’ is not recognized as an internal or external command, operable program or batch file
  18. How do I convert a double into a string in C++?
  19. How to create timer events using C++ 11?
  20. How to concatenate two strings in C++?
  21. ‘g++’ is not recognized as an internal or external command, operable program or batch file
  22. Read file line by line using ifstream in C++
  23. error: lvalue required as unary & operand
  24. What is use of c_str function In c++
  25. Is there a decent wait function in C++?
  26. What does T&& (double ampersand) mean in C++11?
  27. C++ – No matching member function for call to ‘push_back’
  28. error: lvalue required as unary & operand
  29. C/C++ JSON parser
  30. C++ Parsing input string to variables
  31. ‘cout’ was not declared in this scope
  32. Segmentation fault error 11 C++
  33. Why doesn’t C++ have a garbage collector?
  34. How does ifstream’s eof() work?
  35. terminate called after throwing an instance of ‘std::invalid_argument’ what(): stoi
  36. Using O_RDWR vs O_RDONLY | O_WRONLY
  37. How to implement the factory method pattern in C++ correctly
  38. c++ array – expression must have a constant value
  39. getline() does not work if used after some inputs
  40. Passing a 2D array to a C++ function
  41. ‘typeid’ versus ‘typeof’ in C++
  42. Fatal error: iostream: No such file or directory in compiling C program using GCC
  43. Thread pooling in C++11
  44. Callback functions in C++
  45. Reading from text file until EOF repeats last line
  46. How does std::forward work? [duplicate]
  47. Examples of good gotos in C or C++
  48. Sleep function in C++
  49. Deleting a dynamically allocated 2D array
  50. How to add element to C++ array?
  51. Difference of keywords ‘typename’ and ‘class’ in templates?
  52. Error: Jump to case label in switch statement
  53. What does int & mean
  54. Split a string into an array in C++
  55. splitting a string into an array in C++ without using vector
  56. Remove spaces from std::string in C++
  57. How to use glOrtho() in OpenGL?
  58. error: ‘ostream’ does not name a type
  59. Remove spaces from std::string in C++
  60. Read data from a file into an array – C++
  61. Unknown override specifier, missing type specifier
  62. What is the preferred way to include error messages in C++?
  63. How to Convert a C++ String to Uppercase
  64. C++ Fractions Class
  65. #pragma once vs include guards?
  66. Debug vs Release in CMake
  67. C++ Remove punctuation from String
  68. prototype for “….” does not match any in class “…”
  69. Cannot open Windows.h in Microsoft Visual Studio
  70. Nested For – Loops to create multiplication table C++
  71. Reference to non-static member function must be called
  72. Call to non-static member function without an object argument compiler error
  73. How can I assign an array from an initializer list?
  74. I get this error: “glibc detected”
  75. How can I get and use the header file in my C++ program?
  76. cin.eof() functionality
  77. Implementing a tree in C++
  78. Drawing Circle with OpenGL
  79. Run-Time Check Failure #2 – Stack around the variable ‘foo’ was corrupted
  80. How to implement “Press Any Key To Exit”
  81. Reading and writing binary file
  82. C++ ostream and ofstream conversions
  83. C++ discards qualifiers
  84. What is the source of the data for the ProgramFiles, ProgramW6432Dir, ProgramFilesDir (x86), CommonProgramFiles environment variables?
  85. C++ : Exception occurred in script: basic_string::_S_construct NULL not valid
  86. Xcode 11.1: iostream’ file not found
  87. non-member function cannot have cv-qualifier
  88. too many initializers for ‘int [0]’ c++
  89. function does not take 1 arguments c++
  90. overloaded function with no contextual type information
  91. Multiple inputs on one line
  92. Why do I get: -9223372036854775808
  93. Return a 2d array from a function
  94. Linker error: “linker input file unused because linking not done”, undefined reference to a function in that file
  95. What is the difference among ios::app, out, and trunc in c++?
  96. Where can I find ‘winmm.lib’ (I’m using Visual Studio 2012)
  97. What is a `char*`?
  98. Does static constexpr variable inside a function make sense?
  99. “Incomplete type not allowed ” when creating std::ofstream objects
  100. Getting the error floating point exception: 8

Leave a Comment