Custom query using WP_Query is not working

Its not clear what the goal is here, but here are some suggestions:

  • In general, the pre_get_posts hook is not a good place to instantiate a secondary query to display HTML.

  • Your current setup will result in an infinite-loop, because when you instantiate WP_Query within the pre_get_posts callback, you will instantiate it recursively, until you reach the recursive limit with an error.

  • There are ways to instantiate a WP_Query within the pre_get_posts, by removing the callback after the first run, but I don’t think that’s what you’re after.

  • Remove this part from your function:

    if( is_home() && $query->is_main_query()){
    global $wp_query;

    and e.g. display the function in your home template instead. Note that $query is undefined in that line.

  • There’s also the handy get_template_part() if you want to resuse template partials.

  • You might also want to consider a proper function prefix, instead of my_, to avoid possible name collisions.

Related Posts:

  1. Nested meta_query with multiple relation keys
  2. numberposts? showposts? posts_per_page?
  3. How can I save an array from a random post sequence for later use?
  4. All-in-One Event Calendar: Custom Query – Getting each event Instance [closed]
  5. Is there an action/filter called when WP_Query->query is finished and assigns posts
  6. Limit search results to exact match
  7. Highlighting Sub topic in a post?
  8. Pagination Not working on Home Page with 2 Query
  9. Multiple keyword search
  10. Get number of comments after modifying comment query
  11. Show default content if custom WP_Query has no posts
  12. Include Sticky Posts with Custom Query
  13. $wpdb->insert inserting two rows in database
  14. Create unique page without header.php for json feed
  15. Sub-loop / nested loops Best Practices
  16. How to loop for every result found in the_content() when using the search query?
  17. Is there any advantage of using default WordPress Search instead of creating a custom one?
  18. Order By table field comment_status in WordPress > 4.0
  19. Clean up WordPress code that repeats
  20. How to optimize multiple WP_Query() calls on one page?
  21. Use post object from first query in second query
  22. Query to get siblings and parent page
  23. How to list custom fields as headers and list all pages sharing that custom field under it?
  24. Cutom wp_query for geolocation search, pagination not working
  25. Include data from custom table in WP_Query
  26. echo a specific meta_key queried through a custom post
  27. WP Group posts by year(desc) > month(desc) > date(asc)
  28. How to order posts on each different category?
  29. Get specific ACF key and value from all posts – no access to DB
  30. Orderby two meta fields not working
  31. Custom wp_query – I’m getting ‘all’ post, not the specific post in the query
  32. meta_query with array as value with multiple arrays
  33. Adding pagination to sub-wp_query within a singular post page
  34. Magazine style frontpage with multiple categories/loops and no duplicate posts
  35. How to make a query returning pages from multiple parents
  36. Prioritising and Ordering Posts By Category Name Using A Custom Loop
  37. Where is this query?
  38. How to use wp query in my custom page without including header and footer in wordpress
  39. Custom order revolution sliders post base slides as inserted in Specific Posts List field
  40. WP Query for all events prior to current date
  41. How to extend WP_query to a specific table?
  42. Display the search results like the original pages
  43. Multi line of $wpdb->query just run 1 time and end the loop right after
  44. Add to search posts query array with post IDS which will appear first
  45. Woocomerce – Order products by float attribute in archive pages
  46. Multiple values in WP_Query : category__and
  47. How to set up pagination for a custom loop on a global template (author.php, tag.php, archive.php?)
  48. Limit the number of posts from a specific category on index.php
  49. Get the type of an advanced custom field (ACF) in a WP_Query loop [closed]
  50. Switched from query_posts to wp_query, pagination no longer working
  51. WP_Query breaks pagination
  52. Pagination problem with multiple loops on the same page
  53. shortcode with $atts with strange results
  54. I need to get all categories from a WP_Query
  55. why ignore_sticky_posts in sticky post query
  56. WP_Query by post ID doesn’t work if post is in custom post_status
  57. Finding all results from database within 500 miles of the given latitude and longitude [closed]
  58. WP Query and order by particular specified IDs
  59. Get the post permalink within the loop but without additional DB query
  60. Display revision if post status is pending
  61. WP Query search for attachments and their exact title
  62. How to add another parameters to WP_Query?
  63. Display link to taxonomy archive only if it has posts with certain custom field values
  64. Display posts with date wordpress default
  65. Query total number of posts
  66. Category attribute not working in custom shortcode
  67. How to display a posts 1 year ago with custom WP_Query loop?
  68. WC displaying products from category
  69. pagination with numbers for WP_User_Query
  70. Stuck in the query loop
  71. Filter wordpress post categories with jquery/ajax and pagination?
  72. How to display the featured image for each post?
  73. Is there a way to make this kind of loop shorter and nicer?
  74. WP Query ordering on a meta field for posts with a date in the future not ordering by datetime
  75. Merge 2 custom post type posts and taxonomy terms and sort ascending
  76. Pagination on template page for custom query redirecting to index.php
  77. Exclude authors IDs from WP_Query
  78. Exec wp query in slow motion to avoid memory error?
  79. Remove post type filter added by the plugin in the final query
  80. How to get more data of a post by wp_query
  81. Query of all pages, including children, ordered by meta key
  82. WP_User_Query orderby meta_val_num
  83. Query Taxonomy By Page Title
  84. Unable to paginate a custom page query
  85. How to change the default post type over the loop?
  86. Search filter between promo and exact price
  87. Bootstrap grid while loop
  88. search multiple keywords with wp_query using one query
  89. Order posts by tags count?
  90. Pre get posts sort by meta key returns no results if meta key does not exist
  91. Search has query that will return no results
  92. remove_action – pre_get_posts – does not restore original query
  93. How to define a custom hierarchy for terms?
  94. WP_User_Query not searching numbers?
  95. Best way to Order Post in Home without a plugin
  96. Retrieving category pages from subcategory returns empty sets
  97. Loop through multiple custom fields with increasing number
  98. Different number of posts showing in development vs production server
  99. Get WP_Query query after execution?
  100. WordPress extremely slow when using get_posts with multiple meta_query relations
tech