Why is this vector iterator not incrementable?

erase invalidates the iterator. You can’t use it any more. Luckily for you, it returns an iterator that you can use:

vector <Base*>::iterator deleteIterator = m_basesVector.begin();
while (deleteIterator != m_basesVector.end()) {
    deleteIterator = m_basesVector.erase(deleteIterator);
}

Or:

m_basesVector.clear();

Are you responsible for freeing the memory referred to by the pointers in the vector? If that’s the reason that you’re iterating (and your real program has more code that you haven’t shown, that frees those objects in the loop), then bear in mind that erasing from the beginning of a vector is a slow operation, because at each step, all the elements of the vector have to be shifted down one place. Better would be to loop over the vector freeing everything (then clear() the vector, although as Mike says that’s not necessary if the vector is a member of an object that’s being destroyed).

Related Posts:

  1. How to navigate through a vector using iterators? (C++)
  2. How to iterate over a vector?
  3. Is “delete this” allowed in C++?
  4. How to implement 2D vector array?
  5. What is the easiest way to initialize a std::vector with hardcoded elements?
  6. Vector of Vectors to create matrix
  7. How to find out if an item is present in a std::vector?
  8. How do I print out the contents of a vector?
  9. check if a std::vector contains a certain object?
  10. C++ for each, pulling from vector elements
  11. How do I erase an element from std::vector<> by index?
  12. What is the array form of ‘delete’?
  13. Is it more efficient to copy a vector by reserving and copying, or by creating and swapping? [duplicate]
  14. How do I reverse a C++ vector?
  15. Debug assertion failed. C++ vector subscript out of range
  16. No matching member function for call to ‘push_back’ error
  17. Pass a vector by reference C++
  18. Why there is no pop_front method in C++ std::vector?
  19. Initializing a two dimensional std::vector
  20. C++ – No matching member function for call to ‘push_back’
  21. Debug assertion failed. C++ vector subscript out of range
  22. Vector is not a Template?
  23. Displaying a vector of strings in C++
  24. ‘vector’ in namespace ‘std’ does not have a template type
  25. Pointer to incomplete class type is not allowed
  26. Why use string::iterator rather than index?
  27. C++ error: Undefined symbols for architecture x86_64
  28. Vector of structs initialization
  29. Converting a vector to string
  30. vector::size_type in C++
  31. Why use a new call with a C++ ‘vector’?
  32. Why doesn’t std::vector::push_front() exist?
  33. C++ delete vector, objects, free memory
  34. How to access the contents of a vector from a pointer to the vector in C++?
  35. Insert object at index of vector c++
  36. Deleting a dynamically allocated 2D array
  37. How to convert vector to array
  38. No operator << matches these operands
  39. Initialize empty vector in structure – c++
  40. splitting a string into an array in C++ without using vector
  41. What is the difference between const_iterator and non-const iterator in the C++ STL?
  42. What’s the most efficient way to erase duplicates and sort a vector?
  43. Best way to extract a subvector from a vector?
  44. How can I iterate through a string and also know the index (current position)?
  45. How do malloc() and free() work?
  46. Deleting an object in C++
  47. Appending a vector to a vector
  48. How to initialize a vector of pointers
  49. C++ Erase vector element by value rather than by position?
  50. why can’t I dereference an iterator?
  51. Correct way to work with vector of arrays
  52. C++ error: double free or corruption (fasttop)
  53. error C2106: ‘=’ : left operand must be l-value
  54. I get this error: “glibc detected”
  55. Iterator Loop vs index loop
  56. How to create a vector of class objects in C++?
  57. “vector” was not declared in this scope
  58. Vector declaration “expected parameter declarator”
  59. Different ways to deallocate an array – c++
  60. Why can’t I make a vector of references?
  61. Displaying contents of a vector container in C++
  62. What is the size of sizeof(vector)? C++
  63. List iterator not dereferencable?
  64. c++ vector bubble sort
  65. clearing a vector of pointers [duplicate]
  66. “Cannot allocate an object of abstract type” error
  67. Floating point exception( core dump
  68. Passing Arrays to Function in C++
  69. Return array in a function
  70. Identifier not found error on function call
  71. What causes a SIGABRT fault?
  72. Graphics Library for C++
  73. ‘cout’ was not declared in this scope
  74. What is the difference between const int*, const int * const, and int const *?
  75. warning: ISO C++ forbids variable length array
  76. cin >> “no operator matches these operands”
  77. C++ Structure Initialization
  78. expression preceding parentheses of apparent call must have (pointer-to-) function type
  79. Enum to String C++
  80. glm rotate usage in Opengl
  81. Debug assertion failed
  82. “Implicit instantiation of undefined template” when forward declaring template class
  83. “…redeclared as different kind of symbol”?
  84. Is there a standard C++ grammar?
  85. invalid use of non-static data member
  86. C: using strtol endptr is never NULL, cannot check if value is integer only?
  87. use of class template requires template argument list
  88. Why would this give a Use of uninitialised value of size 8
  89. C++ Error: Type Name is Not Allowed
  90. Remove last character from C++ string
  91. plotting package for c++
  92. Initializing pointers in C++
  93. Static vs dynamic type checking in C++
  94. “No rule to make target ‘install'”… But Makefile exists
  95. Is it still safe to delete nullptr in c++0x?
  96. Declaration is incompatible with type
  97. One or more multiply defined symbols found
  98. I’m getting the error “stoi is not a member of std” in myprogramminglab [duplicate]
  99. Template constructor in a class template – how to explicitly specify template argument for the 2nd parameter?
  100. C++ float array initialization 

Leave a Comment