custom post type single page template not working

Please see the Template Hierarchy. There is no template-portfolio.php template. It needs to be archive-portfolio.php.

Also, you should not be using a custom query*. Use the main query in your post type archive templates. WordPress already queries the correct posts for you.

So remove:

$portfolio = new WP_Query('post_type'=> 'portfolio');

And replace:

while ($portfolio-> have_posts() ) :
    $portfolio->the_post(); ?>

With:

while ( have_posts() ) :
    the_post(); ?>

Also, you’re not actually using content-portfolio.php anywhere. You need to actually include it into the archive template. Somewhere between while ( have_posts() ) : and endwhile;:

get_template_part( 'path/to/content-portfolio' ); // Leave off the .php

*It seems like at least 50% of the questions posted here these days are caused by people incorrectly creating a new query when they should be using the main loop. I’d appreciate any insight into where people are learning to do this.

Related Posts:

  1. How to display by default only published posts/pages in the admin area?
  2. Post/Page Preview Template
  3. Using single.php from plugin folder instead of default template folder
  4. posts page – different lengths of excerpt
  5. Static posts page with home.php
  6. Pagination not working on Custom Page Template
  7. how to show all post in my page-grid.php template page
  8. Why does `url_to_postid` return 0 when testing `page_for_posts` Page?
  9. Is it possible to have two different previews of a post (ie. two templates for one post)?
  10. Is there any WordPress alternative to Book module of Drupal?
  11. Display page content AFTER a loop of posts
  12. Single post as homepage?
  13. Posts vs. Pages
  14. How can I pass the ID of a post to a page template by clicking a url?
  15. Using custom post template
  16. Adding buttons to Add New Post and Add New Page
  17. Switch to page template when using post permalink
  18. Get Page ID of blog homepage
  19. Static posts page with home.php
  20. custom post template file not shown, instead all the time 404.php
  21. “about us”, ” contact” sections should be article(post) or page in the simple small Business website?
  22. disable Tab post on nav-menus page (Admin)
  23. Tell WP to use a specific template file in posts
  24. Why won’t pagination work?
  25. WordPress Query Posts From Category Post on Static Page
  26. Create a custom posts page
  27. add_rewrite_rule and template redirect not working
  28. Organization of time insensitive content
  29. Prevent 404 of Author pages without posts
  30. What would causes search to return incorrect results?
  31. Changing permalink of WordPress
  32. Added a ACF field to custom page and want the results to show as a column in admin
  33. Show post count in custom taxonomy page
  34. Put page on Archived statut after end of publication date
  35. post and page and custom post type
  36. Single Sidebar; multiple templates! How?
  37. Is it possible to query a category with specified posts?
  38. How do I set content in my pages so that it remains permanent while blog posts are added below?
  39. Permalink base only for posts
  40. Custom post type template not called
  41. single- and archive- templates not being applied to custom post types, not even after flushing permalinks
  42. My blog “page” used to show a list of posts, but now it’s just showing the page content?
  43. Adding The Post Template Dropdown to WP-Admin
  44. Allow users to create their own page/s
  45. How to arrange different post categories in template
  46. Make a custom URL and link to custom Template
  47. how to style an individual page in a category [duplicate]
  48. Automatically delete default posts and pages on theme install?
  49. Redirecting posts in WordPress to a specific page
  50. How to have more post in a page than in your home page
  51. WordPress “Posts Page” isn’t showing template dropdown
  52. How to have 2 posting pages on a blog
  53. Edit Page button is gone
  54. Custom Field in Featured image for A particular post
  55. Custom permalink structure only for default posts
  56. display order of connections
  57. How to get a nofication when post submitted
  58. How can I create custom button in post.php
  59. Trying to edit the single page from a Custom Post
  60. how to replace embedded “full” sized images within a post with the “large” ones
  61. Downgrade user from role that allows post creation
  62. View Private Published Page with URL Code (no login required)
  63. Why aren’t my posts/pages showing up in my WordPress Theme?
  64. WordPress custom Query for Posts in Category display posts multiple times
  65. Add a custom meta box in the post options that loads some html code in the header
  66. Posts vs Pages and categories
  67. How to dynamically parse and transform post/page content before displaying it?
  68. Using setup_postdata() with multi-dimensional array
  69. how to set social icons to product / post template (Auros theme)? [closed]
  70. $_GET parametters not working in an specific template
  71. How to create custom layouts and static pages in themes for clients
  72. Display a post via template
  73. I don’t want the complete article to show on homepage
  74. posts going to 2 pages/categories only show up in 1
  75. Archieve page, Advertisement Every 3 Posts
  76. How to output all taxonomy links from a custom post type in a menu?
  77. Prevent duplicate pages from being added
  78. Can I style single post that are in multiple catergories?
  79. Separate blog and reviews categories
  80. How do I change the template specifically for single posts?
  81. Change the size of the featured image for post?
  82. Go back to the exact post page number
  83. Customizing a new page used for blog posts with Avada theme
  84. Remove status ‘archived’ from the default post and page view
  85. How to invoke a HTML custom button based on a HTML dropdownlist menu
  86. Custom Post Type Rewrite URL
  87. Custom Post Types and Broken Permalinks
  88. The first post appears twice
  89. How to add post under particular pages? Like website.com/page1/post1
  90. I lost the link to my posts in my menu bar
  91. Show Posts By Custom Field
  92. Customize search results to include custom posts and display in a specific template page
  93. Custom permalink based on custom post type fields
  94. How can i add new post on new page
  95. Custom Post Title as search term
  96. CSS – Change height of Storefront / WooCommerce product categories, but not products
  97. How to add a new page that will function as a separate blog/news article page
  98. Cannot Create a new Post [closed]
  99. Create a page for each database table entries
  100. I have a website issue I am trying to resolve
techhipbettruvabetnorabahisbahis forumutaraftarium24eduseduedueduseduseduedusedusedusedus