Could use some help moving site to subdirectory, what am i doing wrong?

If you move a site, there are many instances in the database that have the URL hard-coded (media file pointers are one). You need to replace the old URL with the new one. You can do that with a search/replace plugin, or manually.

BUt the easiest way to do that, IMHO, is to use the “Clone” plugin from Automaticc. You install the plugin on the old and new sites (no matter where they are). You make sure the new site works at it’s new (temporary) URL (like www.example.com/foldername).

So, install a brand new instance of WP on the new folder. Make sure you can log in there. Install the Clone plugin on the new place. Don’t need anything else installed, as everything will be replaced.

Then you log into the old site, install the Clone plugin, and run the backup program. Copy the backup to local computer. Make sure you know the admin user account of the old site, because everything is replaced on the new site – user accounts also.

Then (in a new browser window), change your hosting to point the domain to the new folder (say ‘foldername’). Change the URLs in the wp-options table manually to the domain name (from www.example.com/foldername to www.example.com). Make sure you can log into the new domain (with the new sites’ credentials).

Install the Clone plugin on the new place (if not already there). Restore the site the zip file you saved locally. You’ll then need to log in with credentials from the old place. And now www.example.com will be pointing to your subfolder.

Note: I’m not a big fan of making the URL change in the config file as you did. I like to have the correct URL in the wp-options table (in two places). Note that any URL settings in the config file override the wp-options settings – I just like it in wp-options so I don’t confuse myself later on.