Create Customization Controls from Array

Please add “;” after $i = $i++ and see if that fixes your issue

foreach ($socialIcons as $icon) {
  $i = $i++;
  $wp_customize->add_setting(
    'pxk_href_' . $icon['name'], // use this in twig file call to theme_mod
    array(
      'default'         => '',
      'transport'       => 'postMessage',
      'priority'        => $i
    )
  );