PHP if not statements

Your logic is slightly off. The second || should be &&:

if ((!isset($action)) || ($action != "add" && $action != "delete"))

You can see why your original line fails by trying out a sample value. Let’s say $action is "delete". Here’s how the condition reduces down step by step:

// $action == "delete"
if ((!isset($action)) || ($action != "add" || $action != "delete"))
if ((!true) || ($action != "add" || $action != "delete"))
if (false || ($action != "add" || $action != "delete"))
if ($action != "add" || $action != "delete")
if (true || $action != "delete")
if (true || false)
if (true)

Oops! The condition just succeeded and printed “error”, but it was supposed to fail. In fact, if you think about it, no matter what the value of $action is, one of the two != tests will return true. Switch the || to && and then the second to last line becomes if (true && false), which properly reduces to if (false).

There is a way to use || and have the test work, by the way. You have to negate everything else using De Morgan’s law, i.e.:

if ((!isset($action)) || !($action == "add" || $action == "delete"))

You can read that in English as “if action is not (either add or remove), then”.

Related Posts:

  1. How to replace “if” statement with a ternary operator ( ? : )?
  2. break out of if and foreach
  3. PHP Like thing similar to MySQL Like, for if statement?
  4. Replace ' and similar html codes with their correspondent character?
  5. Google Calendar API event update always return 404 “not found” error
  6. How to prevent the “Confirm Form Resubmission” dialog?
  7. navigate back with PHP form submission
  8. How to set 777 permission on a particular folder? [closed]
  9. How do I make a redirect in PHP?
  10. List of All Locales and Their Short Codes?
  11. Difference between “as $key => $value” and “as $value” in PHP foreach
  12. How do I get a YouTube video thumbnail from the YouTube API?
  13. What is a slug?
  14. Visual list of all installed fonts with respective pangram phrase?
  15. How to avoid Request Entity Too Large 413 error
  16. How to log in to phpMyAdmin with WAMP, what is the username and password?
  17. Array to String PHP?
  18. Should I use mysqli_real_escape string() or mysql_real_escape_string() for form data?
  19. count() parameter must be an array or an object that implements countable in laravel
  20. regex match any whitespace
  21. What’s the net::ERR_HTTP2_PROTOCOL_ERROR about?
  22. How to fix “Headers already sent” error in PHP
  23. currently unable to handle this request HTTP ERROR 500
  24. PHP page redirect
  25. Whoops, looks like something went wrong. Laravel 5.0
  26. PHP “or” Syntax
  27. Fatal error: Call to undefined function mysql_connect()
  28. How to fix “Headers already sent” error in PHP
  29. “Notice: Undefined variable”, “Notice: Undefined index”, and “Notice: Undefined offset” using PHP
  30. What are namespaces?
  31. Get the full URL in PHP
  32. PDOException SQLSTATE[HY000] [2002] No such file or directory
  33. http://localhost:80 is not working on running Apache server through UniServer ZeroXIII
  34. PDOException SQLSTATE[HY000] [2002] No such file or directory
  35. Mysql query- How to use contains?
  36. How do I get PHP errors to display?
  37. S_SESSION variable (user role) not recognised
  38. What are the main differences between PHPExcel and PhpSpreadsheet?
  39. Is SAJAX dead? What to replace with?
  40. How do I resolve a HTTP 414 “Request URI too long” error?
  41. Get the full URL in PHP
  42. How do I check if a string contains a specific word?
  43. PDOException: SQLSTATE[HY000] [2002] No such file or directory
  44. xajax expanding list query
  45. How to force file download with PHP
  46. How do I get a file extension in PHP?
  47. How to Set Category Page as Home Page in Prestashop
  48. Get the full URL in PHP
  49. Data source name not found, and no default driver specified
  50. mysqli_fetch_array() expects parameter 1 to be mysqli_result, boolean given in
  51. Invalid column count in CSV input on line 1 Error
  52. Warning: mysqli_fetch_array() expects parameter 1 to be mysqli_result, object given in
  53. How to copy a file from one directory to another using PHP?
  54. How to check if a string starts with a specified string?
  55. what does PHP die() return
  56. Invalid column count in CSV input on line 1 Error
  57. how to replace quotation marks with \”
  58. Getting an error when I visit http://localhost
  59. How do I redirect a page in jQuery?
  60. mcrypt is deprecated, what is the alternative?
  61. How can I find my php.ini on wordpress?
  62. mysqli_real_connect(): (HY000/2002): No such file or directory
  63. Convert a PHP object to an associative array
  64. XAMPP Port 80 in use by “Unable to open process” with PID 4
  65. PHP + curl, HTTP POST sample code?
  66. PHP random string generator
  67. How to echo or print an array in PHP?
  68. Fatal error: Call to undefined function mysqli_connect()
  69. What are the differences in die() and exit() in PHP?
  70. How to parse a CSV file using PHP
  71. How to call a JavaScript function from PHP?
  72. Cannot use object of type stdClass as array?
  73. Is a new line = \n OR \r\n?
  74. What is difference between PHP cli and PHP cgi?
  75. Resize image in PHP
  76. Error 500: Premature end of script headers
  77. Cookies vs. sessions
  78. Expected status code 200 but received 500
  79. Regex to check for new line
  80. $wpdb->update or $wpdb->insert results in slashes being added in front of quotes
  81. PDO with INSERT INTO through prepared statements
  82. Illegal string offset Warning PHP
  83. Why use $_SERVER[‘PHP_SELF’] instead of “”
  84. phpMyAdmin: secret passphrase?
  85. Elegant way to search for UTF-8 files with BOM?
  86. What’s the purpose of ini_set() in php? (especially for error reporting)
  87. Can you “compile” PHP code and upload a binary-ish file, which will just be run by the byte code interpreter?
  88. How to get the file extension in PHP?
  89. Are there dictionaries in php?
  90. why use 0xffff over 65535
  91. Email Not Sending from Byethost Hosting
  92. Is SAJAX dead? What to replace with?
  93. .rar, .zip files MIME Type
  94. Invalid argument supplied for foreach()
  95. Remove the last character from a string
  96. PHP how to make URL something like product.php?id=1
  97. Send email with PHP from html form on submit with the same script
  98. Multiple file upload in php
  99. How to prevent Browser cache for php site
  100. laravel updateOrCreate method

Leave a Comment