pre_get_posts dont firing… Anybody knows whats the wrong with my code?

There are a couple of problems with your condition:

A single query cannot match all of your conditions – it can’t be a tag as well as search, for example. You need to use || (or) and possibly nest – so for example,

if(!is_admin() && ($query->is_home() || $query->is_search())) {

This says, “if we’re not in the admin area AND either it’s a home query or a search query, then do this.”

Also, some of the is_ conditions you’re trying to meet aren’t the way you test the query. is_front_page() cannot be called because the query isn’t set up yet – but is_home() can. Read up in the documentation to learn more about which conditionals are valid, and then you can try a simplified query first – such as if(!is_admin()) to make sure it’s running – then add additional conditions one at a time so you can tell which one specifically is causing you problems.

Related Posts:

  1. Sticky Posts exceed posts per page limit
  2. Theres a way to use $query->set(‘tax_query’ in pre_get_posts filter?
  3. Modify Taxonomy pages to exclude items in child taxonomies
  4. Obliterate the main query and replace it
  5. Post injection – how to exclude the original post
  6. Adding meta_key via pre_get_posts causes navigation to disappear
  7. Sorting posts that has a meta value first then the rest of the posts
  8. pre_get_posts on a page
  9. How pre_get_posts filter by roles in WP Admin
  10. Weird problem with pre_get_posts and $query->is_page()
  11. Why is ‘pre_get_posts’ having no effect?
  12. Date Query to Pull Current and Future Posts
  13. pre_get_posts all posts and custom post type with certain tag
  14. Using Sessions to Filter Posts – bad thing?
  15. pre_get_posts and the blog page
  16. Archive by custom post type and custom date field
  17. pre_get_post filter returns results when there should not be
  18. Trying to exclude first 5 posts from the first page on the homepage
  19. Exclude a WordPress post from pre_get_posts if a field is null
  20. Why the ‘date_query’ is not working in ‘pre_get_posts’ hook?
  21. Only show certain post types in recent posts widget
  22. pre_get_posts for exclude category
  23. pre_get_posts: using tax_query only for certain post type
  24. Restrict Search Query To After Specific Date
  25. WP_Error not displaying errors
  26. Show all posts even if URL points to a single one
  27. How to achieve post_status__not_in?
  28. Ordering by meta_key
  29. Using a pre_get_posts filter to search for multiple strings on all meta values
  30. Removing taxonomy query by pre_get_posts
  31. Using different parameters for different queries with pre get posts in functions.php
  32. how to restrict posts_request filter to the main query only
  33. Automatically applying a pre_get_posts filter for child categories only
  34. How to override a query and display specific page by ID?
  35. pre_get_posts variables
  36. Another query in pre_get_post cause memory issue
  37. pre_get_posts having no effect on my category archive
  38. pre_get_posts returns non property object when using posts__not_in
  39. Override tax_query with pre_get_posts to include other term_ids on a single category
  40. $query->is_main_query() is causing query’s tax_query to be ignored
  41. Menu disappears when meta_key changed [closed]
  42. pre_get_posts with multiple queries
  43. How to show the last and newest modified post in a custom category?
  44. Altering the main query using get_post_meta() in pre_get_posts
  45. Why query by specific date with variables doesn’t return same result that with harcoded integers?
  46. Sort WordPress Archive by multiple oderby arguments in pre_get_posts action
  47. Exclude post type with pre_get_posts?
  48. Exclude page by title for non admins
  49. problem with setting tax_query in pre_get_posts
  50. Problem ID to exclude specific posts from category
  51. Modify Taxonomy pages to exclude items in child taxonomies
  52. Modify author archive query to combine two queries
  53. Change post order on archive to be displayed by most commented being ignored by theme
  54. Complex query using pre_get_posts
  55. Super confusing ‘pre_get_posts’ behavior with $query->set
  56. Having trouble with settings terms as array in pre_get_posts
  57. Override main query for page template
  58. Querying custom taxonomy on category-specific page is overwritten by function
  59. how to get content from other site and show it?
  60. Insert a variable in pre_get_posts
  61. Extend taxonomy term page with other posts
  62. Set a custom number of posts on the first page
  63. Why does this query not SELECT post IDs like a normal query would?
  64. Please ensure me that I’m not crazy using the pre_get_posts [closed]
  65. How to pass >= condition filter to my year custom tax_query
  66. What is the proper way to use pre_get_post?
  67. pre_get_posts has php notice when not on CPT archive
  68. Duplicating event posts in wordpress
  69. Using pre_get_posts to rewrite search query to display posts from multiple taxonomies
  70. Varying the number of posts per page from the first one
  71. How to alter query order direction using $query->set(‘order’, ‘ASC’); inside a pre_get_posts filter?
  72. Meta Query “IN” doesn’t work with ACF checkbox filter
  73. pre_get_posts with WooCommerce Shortcode Query
  74. How to sort posts in admin by titles with dd.mm.yyyy format?
  75. Building an Advanced Search (text, tags, category, custom fields) – Getting the wrong SQL query
  76. Including only current user’s posts in search
  77. Advanced or not so advanced pre_get_posts query
  78. Showing posts from different categories and from custom post type
  79. Custom Post Type Archive Error, Takes Last Post as Title and Doesn’t Work
  80. WordPress Screwing Up ‘orderby’ => ‘meta_value_num’ in ‘pre_get_posts’
  81. Can a link in WordPress contain a query string that is picked up as $_POST
  82. Child pages not affected by orderby
  83. pre_get_posts to hide everywhere posts from “Archive” category
  84. Sort categories by custom field in WordPress admin
  85. Order column custom date using pre_get_posts
  86. Setting user permissions per post
  87. How to hide private posts even if user is admin
  88. How to show only specific category post by user role without plugin and restrict all other cats
  89. How order by works?
  90. WP search in metadata post
  91. pre_get_posts with multiple post types AND a meta_key
  92. How to use get_pages( ) correctly with ‘child_of’ to replace page with child page
  93. wp_query – Modify $query to include duplicate content
  94. Filter WP_Query output before it is accessed (pre_get_posts)?
  95. Problem to show custom post type in archive page category wise
  96. Adding custom post types to the default loop, yet only posts that has terms from the core taxonomies
  97. Pre_Get_Posts order DESC not registering
  98. Avoiding page loop
  99. pre_get_posts causes Custom Posts appear under ‘Pages’ menu
  100. How to put posts with some taxonomy on top of others in `pre_get_posts`