return values from hooks do_action and apply_filters, which is better

Contrary to the comments… I’d say that you should use filter as in method 1 because…

  1. Message will depend on quite a few things right now, You just do a test if statement, later on message may depend on some other factors ( like maybe validating a nonce on failure giving message ‘None invalid’ ).
  2. Actions help in extending your code’s functionality… later on some other plugin ( or maybe theme, if your plugin get’s incredibly famous 😀 ) may wanna change the message to be more friendly like Sorry, couldn't update.

It’s always easier with filters, remember whenever you have a value involved ( like an output message, or value saved into db ) it’s best to use filters.

Related Posts:

  1. Trouble understanding apply_filters()
  2. What is the very earliest action hook you can call?
  3. Earliest hook to reliably get $post/$posts
  4. Remove Editor From Homepage
  5. Advanced Custom Fields and Yoast SEO keyword analysis [closed]
  6. How to check if a hook is hooked or not?
  7. Is it possible to use object in add_action?
  8. Store source permalink on XMLRPC calls
  9. How to make post and comment count unclickable with dashboard_glance_items hook
  10. Hook into admin post list page
  11. Anyway to edit the titlebar of WordPress Widgets in the Admin area?
  12. Using hooks to place content in theme dynamically
  13. About Hooks and Filters
  14. PHP5, Inheritance, Singleton – action & filter hook limitations
  15. Should I use add_action(‘publish_post or add_filter(‘publish_post?
  16. Please explain me what the do_action does
  17. Apply the_title filter to post titles AND backend auto social-sharing plugin, but not nav menu
  18. changing variable through filters or action hooks
  19. Apply a filter only once
  20. How to get list of all hooks of current theme / plugin?
  21. How does WordPress call functions attached to a certain action hook before calling functions attached to other hooks
  22. How to get current action?
  23. Conditionally call add_action depending on post_type?
  24. how to change appearence of the content of default post list columns?
  25. Anonymous function is executed twice in wp_head while added from the_posts filter?
  26. Explanation for remove_filter used in the below code [closed]
  27. How to change the blog title with add_filter? details below
  28. How To Get User Data in Callback Function for pre_user_nicename?
  29. What’s the best way to split admin-only functionality in the theme’s functions.php file?
  30. When to use actions and when to use filters
  31. Return a custom value in a function added to an action hook
  32. Is possible dequeue/remove style from wp_footer() hook and add on wp_head() hook?
  33. Same Conditionals Not Working on Two Different Hooks
  34. How to call a function or method that is Namespaced using another plugin
  35. How to change currency programmatically on creating order action?
  36. Removing an action, or dequeueing style – Both not working
  37. Can the wp_filter object hold multiple values with the same key
  38. apply_filters/do_action tag characters limit
  39. Replace a word with a word in the URL string
  40. Is there a filter called ‘network_admin_init’?
  41. Insert term when page is published – avoid duplicates after edits
  42. Capture post content before page renders
  43. Correct method of redirecting user login
  44. Shortcodes — Using add_action, add_filter in the shortcode
  45. How to remove action with slashes and arrows?
  46. Can the wordpress color palettes by changed through Javascript?
  47. How do I use remove_action on an add_action that uses an array?
  48. Changing WordPress core without hacking core
  49. How to pass variables to custom filter from multiple functions
  50. Building a request processor for multi-page forms, etc using $_GET requests
  51. Comment search plugin
  52. How to customize the “Insert/edit link” popup box?
  53. How to get a single hook from wp_head()?
  54. How can I output all apply_filters and do_action?
  55. How to allow code block in wordpress comments
  56. Add a filter inside an action init
  57. remove_action: how to access to a method in an child class?
  58. Is it possible to apply_filter on a wp_ajax_ action?
  59. Add a filter to an action [closed]
  60. How can I specify the post status of an untrashed post?
  61. why require – does not load filter
  62. Most performant/functional way to add actions/filters?
  63. Remove tags without a specific meta key from “choose from the most used tags”
  64. Register new user, assign custom role then send email
  65. What is the action hook to use if you want to capture the new password during password change?
  66. Echo string in admin panel footer beside version no
  67. How to change default text for specific post type
  68. How can I edit comment meta value before it is saved?
  69. Disable sanitize_file_name on upload without modifying functions.php
  70. Redirect after post deleted
  71. What is the action or filter for adding information under the Permalink in Edit Post/Page?
  72. Making an add_filter() call from within an add_filter() call
  73. Plugin default settings hook
  74. alternative to the_content filter
  75. How would I use a filter to remove header banner on certain post types
  76. Action hook to control access to certain parts of my site
  77. Finding actual functions added to hooks and filters
  78. output custom Posts on a Page
  79. Replace Data In Post & Update Meta Field Post Is Saved
  80. How to pass a variable between filter/action functions?
  81. style_loader_tag not changing stylesheet to preload
  82. Adding link options in insert/edit link dialog window
  83. add_action with associative array
  84. Does anybody know what the $current_screen ->id for customizer.php is?
  85. adding an action inside if condition not working
  86. Action for opening attachment or manipulating all attachment links
  87. Put data in my-account/view-order/id/ page
  88. What action/filter can be used for modifying the page to be rendered?
  89. Hook inside a hook
  90. What problems could happen if I replaced add_filter and add_action with the function calling
  91. check, if any “add_action” function contains string XXXXXXXXX
  92. Remove action added from class
  93. Adding to an array & passing it through do_action/apply_filters
  94. Hook into ‘when user logs in’ [persistent login]
  95. Custom registration field to SQL database
  96. Is this correct usage of filters in WordPress [closed]
  97. How would I remove an inline googleAPI font script in the the parent theme header.php?
  98. Is it possible to make get variable out of filter in Class?
  99. GET form action. Redirect to self
  100. Can you call a filter hook by “add_action”?