Rewrite custom post type url’s adding meta box values

It sounds like you’re very close here and your only remaining issue is that your permalinks for genres and movies collide.

'movies' CPT permalink
/genres/%custom field meta box value%/%movie%/

'genres' CPT permalink
/genres/%genre%/

The issue here is using the add_permastruct. When it creates the rules for movies, they look something like this:

genres/([^/]+)/([^/]+)(/[0-9]+)?/?$
  => index.php?genre=$matches[1]&movies=$matches[2]&page=$matches[3]

The way request processing works in WordPress, you can’t set multiple post types in the same URL — WordPress stops after the first one. That is, they can be in the pretty URL, but not in the “ugly” one that generates the request and query. Any rewrite rules with movies= cannot contain genre=. Below is the full, exhausting overhaul of rb_add_rewrite_rules. You can pull out any rules you may not need like the attachment urls, feed urls, etc. As always when making rewrite changes, be sure to flush your permalinks by going to Settings->Permalinks and clicking “Save Changes”. Also, make sure 'rewrite' => false is set on both custom post types.

function rb_add_rewrite_rules() {
    add_rewrite_rule( 'genres/[^/]+/[^/]+/attachment/([^/]+)/?$', 'index.php?attachment=$matches[1]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/[^/]+/attachment/([^/]+)/trackback/?$', 'index.php?attachment=$matches[1]&tb=1', 'top' );
    add_rewrite_rule( 'genres/[^/]+/[^/]+/attachment/([^/]+)/feed/(feed|rdf|rss|rss2|atom)/?$', 'index.php?attachment=$matches[1]&feed=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/[^/]+/attachment/([^/]+)/(feed|rdf|rss|rss2|atom)/?$', 'index.php?attachment=$matches[1]&feed=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/[^/]+/attachment/([^/]+)/comment-page-([0-9]{1,})/?$', 'index.php?attachment=$matches[1]&cpage=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/([^/]+)/trackback/?$', 'index.php?movies=$matches[1]&tb=1', 'top' );
    add_rewrite_rule( 'genres/[^/]+/([^/]+)/feed/(feed|rdf|rss|rss2|atom)/?$', 'index.php?movies=$matches[1]&feed=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/([^/]+)/(feed|rdf|rss|rss2|atom)/?$', 'index.php?movies=$matches[1]&feed=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/([^/]+)/page/?([0-9]{1,})/?$', 'index.php?&movies=$matches[1]&paged=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/([^/]+)(/[0-9]+)?/?$', 'index.php?movies=$matches[1]&page=$matches[3]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/[^/]+/([^/]+)/?$', 'index.php?attachment=$matches[1]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/[^/]+/([^/]+)/trackback/?$', 'index.php?attachment=$matches[1]&tb=1', 'top' );
    add_rewrite_rule( 'genres/[^/]+/[^/]+/([^/]+)/feed/(feed|rdf|rss|rss2|atom)/?$', 'index.php?attachment=$matches[1]&feed=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/[^/]+/([^/]+)/(feed|rdf|rss|rss2|atom)/?$', 'index.php?attachment=$matches[1]&feed=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/[^/]+/([^/]+)/comment-page-([0-9]{1,})/?$', 'index.php?attachment=$matches[1]&cpage=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/attachment/([^/]+)/?$', 'index.php?attachment=$matches[1]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/attachment/([^/]+)/trackback/?$', 'index.php?attachment=$matches[1]&tb=1', 'top' );
    add_rewrite_rule( 'genres/[^/]+/attachment/([^/]+)/feed/(feed|rdf|rss|rss2|atom)/?$', 'index.php?attachment=$matches[1]&feed=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/attachment/([^/]+)/(feed|rdf|rss|rss2|atom)/?$', 'index.php?attachment=$matches[1]&feed=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/attachment/([^/]+)/comment-page-([0-9]{1,})/?$', 'index.php?attachment=$matches[1]&cpage=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/([^/]+)/trackback/?$', 'index.php?genre=$matches[1]&tb=1', 'top' );
    add_rewrite_rule( 'genres/([^/]+)/feed/(feed|rdf|rss|rss2|atom)/?$', 'index.php?genre=$matches[1]&feed=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/([^/]+)/(feed|rdf|rss|rss2|atom)/?$', 'index.php?genre=$matches[1]&feed=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/([^/]+)/page/?([0-9]{1,})/?$', 'index.php?genre=$matches[1]&paged=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/([^/]+)(/[0-9]+)?/?$', 'index.php?genre=$matches[1]&page=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/([^/]+)/?$', 'index.php?attachment=$matches[1]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/([^/]+)/trackback/?$', 'index.php?attachment=$matches[1]&tb=1', 'top' );
    add_rewrite_rule( 'genres/[^/]+/([^/]+)/feed/(feed|rdf|rss|rss2|atom)/?$', 'index.php?attachment=$matches[1]&feed=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/([^/]+)/(feed|rdf|rss|rss2|atom)/?$', 'index.php?attachment=$matches[1]&feed=$matches[2]', 'top' );
    add_rewrite_rule( 'genres/[^/]+/([^/]+)/comment-page-([0-9]{1,})/?$', 'index.php?attachment=$matches[1]&cpage=$matches[2]', 'top' );
}

Related Posts:

  1. Adding meta values to permalink
  2. How to filter custom post type archive by meta value
  3. How can I use get_post_meta with add_rewrite_rule to build custom permalinks?
  4. Custom Post Type Date Based Archive URL rewrite [duplicate]
  5. Custom archive URL as a subfolder of the custom post type slug
  6. Custom rewrite rules for archive page and single post
  7. Custom post type yearly/ monthly archive permalinks
  8. Meta_Query as a way how to setup CPT permalinks – is it a good thing?
  9. Archive page with multiple taxonomies rewrite
  10. Permalinks so that one custom post type appears to be a child of another, not working
  11. Taxonomy archives based on Custom Post Type
  12. Custom post type permalink structure with the category also acting as an archive
  13. Prepend meta_value to permalink of post
  14. Multiple parameters in a custom post type url rewrite
  15. Permalinks for CPT breaks permalinks to pages
  16. WP Rewrite Rules – Custom post type & taxonomy
  17. Remove base slug in CPT & CT, use CT in permalink
  18. Custom Post Type rewrite redirects to homepage
  19. single-{post_type}.php is not loaded despite flushing rules
  20. Custom Permalink Tag breaks Pagination
  21. Adding paged query to custom URL rewrite
  22. Custom Post Type rewrite rules not working, how to alter the rewrite order?
  23. Custom Permalink for Taxonimie and Custom Post Type
  24. how to get archive urls with same origin for custom types and terms?
  25. Rewrite numeric ID parameter for hierarchical custom post type
  26. Customising rewrite rules for CPT single post URL to work as paged URL
  27. Remove custom post type slug not working for child pages
  28. add_rewrite_endpoint() and Custom Post Type Archive
  29. Pagination problem
  30. Conditional regex in add_rewrite_rule() for specific query filters & pagination
  31. Permalink Structure CPT With Custom Taxonomy Fails
  32. Query var removed after rewrite
  33. CPT Archive with core Category
  34. Making a custom help center page
  35. Remove url rewrites for registered taxonomies
  36. Rewrite and custom post type: order by custom field not working
  37. CPT custom archive template does not get loaded
  38. Can’t get custom rewrite tag, query var, permastruct (permalink structure), and rewrite rule to work properly together
  39. How can achieve this permalink perfectly? domain.com/%category%/%post-name%
  40. Customize Custom Post Type URL
  41. How do I change the custom taxonomy slug to be the same as the custom post type slug?
  42. Custom taxonomy rewrite with query var returns %2F in URL
  43. Custom Permalinks with CPT and Hierarchical Taxonomies
  44. Rewrites/query for multiple hierarchical custom post types
  45. cpt and page sharing same base permalink
  46. Hide or disallow default custom post type url?
  47. Post Type rewrite rule to point to custom Page/template
  48. Canonical url differs from custom post type archive URLs
  49. Permalink structure with custom taxonomies and custom post type like /parent-tax/child-tax/custom-post-type-name (with no base name)
  50. Pretty URLs and custom post types
  51. Specific routing for CPT
  52. Ignoring slug capitalization on rewrite rule for custom post type archive page
  53. Custom post type archive with page as parent url
  54. Add parent post to Custom Post Type [closed]
  55. Custom Rewrite Rule for Custom Post Type with URL Param
  56. WordPress custom slug rewrite
  57. Custom Permalinks for Custom Post Types
  58. Postname on unique permalink structure appends “-2” for a custom post type. How can I get this to stop happening?
  59. Set parent for custom post type archive rewrite url
  60. Route subpage to Custom Post Type
  61. Rewrite permalink for multiple post types (CPT) with taxonomy term
  62. WordPress custom permalink and archive link for custom post type
  63. Pagination for custom post types – url rewriting
  64. Modifying rewrite rules to use /category//
  65. Add Custom Values to Permalinks Through Custom Fields and Posts
  66. Archive page for custom post type and custom taxonomy
  67. Rewrite rules for custom post type
  68. Custom taxonomy and post type rewrite rules
  69. Pages not appearing?
  70. Url Rewriting a dynamic wordpress page with parameters
  71. Custom taxonomy terms as children of multiple custom post types
  72. Remove cpt slug from url and use custom taxonomy instead breaks all other cpt
  73. multiple URLS for the same page
  74. How to properly set the rewrite rules for this case?
  75. Creating an archive page or simple template to list all values of a custom field of specific post type listing
  76. Change CPT permalink to use the category
  77. add_rewrite_rule wordpress ignoring url pattern, wp rewrite not working
  78. How to fix 404 on post after prepending Custom Post Type url with Custom Taxonomy Term slug
  79. Custom Post Type parent/child relationship rewrite rules for permalinks
  80. Redirect Custom Post Type from Child Taxonomies
  81. Set archive of custom post type like ‘posts’ page in reading settings is set
  82. Rewrite URL of Specific Post of Custom Type
  83. Meta_query by date for Events archive
  84. How to build overlapping custom post_type and taxonomy rewrites without conflicts?
  85. Custom post type rewrite and wp_pagenavi interfering with each other
  86. Show index and not the archive for “Dog Custom Post” with default slug
  87. Custom Post Type rewrite url to /category/pagetitle [duplicate]
  88. WordPress custom post type rewrite rule matches all pages returning 404
  89. page not found for example.com/custom-post-name
  90. Paging not working for hierarchical custom post type
  91. redirect old post type url to new structure url
  92. Archive page for a custom post type using WPML
  93. Why won’t this rewrite rule work?
  94. Rewrite rules causing hole
  95. rewrite rules add a folder in the path
  96. Custom Taxonomy in Permalink from post type
  97. Custom post type permalink structure
  98. add_rewrite_rule not working in Custom Post Type UI Plugin
  99. What is the best way to relate different custom post types?
  100. Dynamic WordPress rewrite rules for multiple custom post types

Leave a Comment