why shouldn’t i save metadata when its a revision

You omitted how is this function called. I assume it is added to save_post action.

This action passes current post id as argument. In case of revision that would be revision id and not parent post id. So, as I see it, there is no reason to save additional data for revision (creating duplicate set of it).

Update.

Scratch that.

I looked through source code. Apparently *_post_meta functions will automatically change to parent post id if passed revision post id. So you might modify original post, thinking you are modifying revision.

Related Posts:

  1. Stop a plugin in the activation process when a certain WP version is not met then show error message in admin_notices action hook
  2. How to Add a Third Level Sub Menu to the WordPress Admin Menu
  3. How to Add an Index to Plugin Database table
  4. Override WordPress user with Oauth2 account
  5. How to add “Stick this post to the front page” to front end?
  6. Creating two database tables via plugin
  7. Is it a good idea to edit an already existing plugin to add more functionality?
  8. How to make media upload private? [duplicate]
  9. How to trace the cause of these PHP notices and warnings for class-wp-query.php?
  10. Admin plugin, how can I output a different content-type?
  11. Modify featured image URL at runtime
  12. Editor access to plugin settings
  13. Some plugins adding full server path after url (with custom wp-content folder)
  14. Custom Widget outputs the input but doesn’t save anything inside the textarea
  15. Woocommerce: Changing the variations select default value? [closed]
  16. Why load_textdomain work but not load_plugin_textdomain?
  17. Get uploaded image url
  18. Akismet plugin is deleting spam despite preferences
  19. Star rating for custom post types [closed]
  20. How WordPress knows where to find locale files?
  21. How to add custom JS to tinymce in wordpress
  22. Collaborative post submission [closed]
  23. Reuse javascripts from plugins within the theme
  24. Correct wp-content ownership and permissions
  25. How to check what plugins used to be on a WordPress installation?
  26. Why isn’t “background-image: url”working with Bootstrap carousel on WP?
  27. Plugin Deactivate Self on Activation Errors
  28. Form doesn’t submit on second submit call
  29. What would be the advantages/disadvantages of remote plugin installation?
  30. How to slice an array using posts_per_page? [closed]
  31. Should I fetch the data managed by a plugin by using its APIs or WordPress APIs?
  32. Use translated taxonomy labels in plugin
  33. Show an image in my header.php
  34. Plugin appends ugly URL string to index
  35. Installing a plugin on a premium site [closed]
  36. White page by using filter template_include
  37. WordPress Keeps Logging Out – What Tests Can I Run to Solve This?
  38. Facebook Messager Plugin
  39. How to save inputed data in a textbox [EDITED] [duplicate]
  40. User switching only with specific role and return
  41. WordPress Payment gateway add on form , how to add form into list or else how to submit form to next step for payment
  42. How WordPress is able to change locale without using setlocale
  43. Better ads plugin has 500.000 entries in wp_postmeta
  44. Render Modula Plugin Shortcode On Ajax Request
  45. Saving widget options from class method
  46. This WordPress plugin isn’t creating links correctly
  47. Basics of changing plugin output
  48. WordPress plugin url for form submit
  49. syntax error, unexpected ‘while’ (t_while) please help :)
  50. dynamic name of the style for wp_enqueue_style
  51. Delete Media not attached with Any posts
  52. remove ad to cart button and view more button if product price is empty
  53. how to add a comment button to be displayed only for the posts in the home page [closed]
  54. Override plugin template
  55. Should meta boxes for specific pages be save in their own plugins?
  56. Change plugin author after someone leaves the company
  57. WordPress Update Question
  58. How to implement a plugin featuring foursquare like check-in
  59. “After file loaded” action
  60. Add_image_size not generating correct size
  61. navigation among single posts
  62. Plug-in that shows x number thumbnails from another post
  63. W3 Total Cache Help – How to update DNS Zone for a static domain [closed]
  64. Show Homepage (only) Hits Count
  65. WordPress jQuery Post – Amending Variable Value Within Function Command
  66. Custom Post Type same name as Category
  67. how to display recent post by category on home page
  68. how to define a html folder to make it work with WordPress commands
  69. Asking help regarding potential malware
  70. wp_mail function not working in WordPress Plugin Boilerplate
  71. How To Remove “All, Publish, Draft and Expired” in Events Dashboard
  72. When/where would want to attach other classes to the base class in a WordPress plugin?
  73. How to find where an image is used by it’s url
  74. checkout stripe with plugin contact form
  75. Disqus comment system not show
  76. Javascript inserted from Plugin pointing to wrong location
  77. Custom plugin which downloads updates from custom endpoint, extracts new version zip into a new name
  78. How to cache for multi server environment? Memcached, Redis or other?
  79. Page takes on two different formats
  80. Cant visualize protected password portfolio elements
  81. How to create multiple pages for PDFs
  82. Creating a comments voting system
  83. How to assign plugin to top level menu?
  84. Rewrite URL to plugin file
  85. Multiple Accounts on 1 email – Multisite
  86. Multiselect value in wp_query
  87. Is it possible to cancel a post status transition?
  88. Retrieve post thumbnails
  89. Why are only inactive plugins showing?
  90. Facebook Like Button with NextGen Gallery
  91. wordpress plugin JSON API search within specific category
  92. when i use wp automatic plugin post shows broken images
  93. how to add “alt” for all image in wordpress
  94. How to display blog posts only authored by the administrator
  95. Contact form 7 – How to send mail to two different E-mail Address [closed]
  96. Seo Problems in My meta Discription [closed]
  97. how to show the data from a myqsl database in a post [closed]
  98. How can I resolve an error on WordPress after PHP update
  99. Remove a specific sitemap from Sitemap_index.xml
  100. Testing Plugin – Install plugin dependencies in testing enviroment
tech