WP_Query and Pagination on a Static front page

I’m not quite sure what do you mean by you have extended the visual composer, but I do have a couple of concerns here.

  • SoC -> From your code I detect that you are using a shortcode, which should have its own separate class. You should not extend the class to the visual editor (at least this is how I read your question). Classes should never multi task, they should do one single duty. This keeps your class extentable, short, easy to maintain and reusable and easy to test

  • Extending the previous point, front end and back end functionalities should not be mixed

  • I don’t see the usefulness of using global $post and setting up post data. Doing this and not resetting postdata afterwards will have unexpected influences on any query afterwards and on the main query. You should drop that completely

  • Never ever use extract() in shortcodes ( and any other function for that matter ). It is very unrealiable and untestable and leads to unexpected output. This makes it extremely hard to debug in case of failures. For this very reason, it was completely removed from core. See trac ticket 22400

  • Because you are using multiple category conditions, and to make it more dynamic, I would rather use a tax_query to handle the conditions. The big plus here would be that you will save on db calls as you can get rid of get_category_by_slug

  • There is no need for wp_reset_query(). This is used with query_posts which you should never ever use. It is a page breaker.

  • Front pages and single pages uses the query variable page (get_query_var( 'page' )) for pagination, and not paged (get_query_var( 'paged' )) as other pages. The query argument for WP_Query for both however is the same, it should be paged, not page. The value to the paged parameter/argument should be page for static front pages and paged for all other pages

You can rewrite your method above as follow: (CAVEAT: Untested)

public function renderPosts( $atts ) 
{
    $attributes = shortcode_atts( array(
        'foo'     => 5, //default of 5
        'include' => 'news-views', // Currently news and views.
        'exclude' => 'game-library' // Exclude this category
    ), $atts);

    /* 
     * For getting the Query variable on a static front page, you have
     * to use 'page' and not 'paged'. Weird.
     */ 
    if ( get_query_var('paged') ) {
        $paged = get_query_var('paged'); 
    } elseif ( get_query_var('page') ) { 
        $paged = get_query_var('page'); 
    } else { 
        $paged = 1; 
    }


    /*
     * Args for the custom query
     */
    $query_args = array(
        'posts_per_page' => intval($attributes['foo']),
        'tax_query'      => array(
            array(
                'taxonomy' => 'category',
                'field' => 'slug',
                'terms' => explode( ',', str_replace( ' ', '', $attributes['include'] ) ),
                'include_children' => false
            ),
            array(
                'taxonomy' => 'category',
                'field' => 'slug',
                'terms' => explode( ',', str_replace( ' ', '', $attributes['exclude'] ) ),
                'operator' => 'NOT IN'
            )
        ),
        'paged' => $paged
    );

    $custom_query = new WP_Query($query_args); 

    $output="";
    if ( $custom_query->have_posts() ) {  

        $output .= '<div id="blogroll">'; 

        while ( $custom_query->have_posts() ) { 

            $custom_query->the_post();

            $output .= "<div class="home_post col span_12 clear-both">";
            $output .=      "<div class="col span_3"><a href="" . get_the_permalink() . "">" . get_the_post_thumbnail(get_the_ID(), 'home_post_thumb') . "</a></div>";
            $output .=      "<div class="col span_9 col_last right-edge">";
            $output .=        "<h2 class="home_post_header">";
            $output .=           '<a href="' . get_the_permalink() . '">' . get_the_title() . "</a>";
            $output .=        "</h2>";
            $output .=        get_the_excerpt();
            $output .=      '<a class="home-more-link" href="' . get_the_permalink() . '"><span class="continue-reading">Read More</span></a>';
            $output .=      "</div>";
            $output .= "</div>";

        }

        wp_reset_postdata();

        $output .= '<div id="pagination" class="blogroll-pagination">' . home_pagination( $custom_query ) . '</div></div>';

    }

    return $output;  
}

Just remember, the I have changed the attributes for readability, include takes a comma separated string of category slugs (include="slug-1, slug-2"). This attribute will be used to include categories. exclude works the same (exclude="slug-1, slug-2"), except that it takes a comma separated string of category slugs

EDIT

I have tested my code and fixed a couple of small bugs. It works as expected if I just create a normal shortcode from it.

PROOF OF CONCEPT – SHORTCODE

add_shortcode( 'testcode', function ( $atts )
{
    $attributes = shortcode_atts( array(
        'foo'     => 5, //default of 5
        'include' => 'news-views', // Currently news and views.
        'exclude' => 'game-library' // Exclude this category
    ), $atts);

    /* 
     * For getting the Query variable on a static front page, you have
     * to use 'page' and not 'paged'. Weird.
     */ 
    if ( get_query_var('paged') ) {
        $paged = get_query_var('paged'); 
    } elseif ( get_query_var('page') ) { 
        $paged = get_query_var('page'); 
    } else { 
        $paged = 1; 
    }


    /*
     * Args for the custom query
     */
    $query_args = array(
        'posts_per_page' => intval($attributes['foo']),
        'tax_query'      => array(
            array(
                'taxonomy' => 'category',
                'field' => 'slug',
                'terms' => explode( ',', str_replace( ' ', '', $attributes['include'] ) ),
                'include_children' => false
            ),
            array(
                'taxonomy' => 'category',
                'field' => 'slug',
                'terms' => explode( ',', str_replace( ' ', '', $attributes['exclude'] ) ),
                'operator' => 'NOT IN'
            )
        ),
        'paged' => $paged
    );

    $custom_query = new WP_Query($query_args); 

    $output="";
    if ( $custom_query->have_posts() ) {  

        $output .= '<div id="blogroll">'; 

        while ( $custom_query->have_posts() ) { 

            $custom_query->the_post();

            $output .= "<div class="home_post col span_12 clear-both">";
            $output .=      "<div class="col span_3"><a href="" . get_the_permalink() . "">" . get_the_post_thumbnail(get_the_ID(), 'home_post_thumb') . "</a></div>";
            $output .=      "<div class="col span_9 col_last right-edge">";
            $output .=        "<h2 class="home_post_header">";
            $output .=           '<a href="' . get_the_permalink() . '">' . get_the_title() . "</a>";
            $output .=        "</h2>";
            $output .=        get_the_excerpt();
            $output .=      '<a class="home-more-link" href="' . get_the_permalink() . '"><span class="continue-reading">Read More</span></a>';
            $output .=      "</div>";
            $output .= "</div>";

        }

        wp_reset_postdata();

        $output .= '<div id="pagination" class="blogroll-pagination">' . home_pagination( $custom_query ) . '</div></div>';

    }

    return $output;  
});

which I use as follow

[testcode include="testslug-1, testslug-2" exclude="testslug-3, testslug-4"]

I have tested your pagination function as well and that also works as expected. 

function home_pagination( $query = null ) 
{

    $big = 999999999; // need an unlikely integer

    if ( get_query_var('paged') ) {
        $paged = get_query_var('paged'); 
    } elseif ( get_query_var('page') ) { 
        $paged = get_query_var('page'); 
    } else { 
        $paged = 1; 
    }


    $pagination = paginate_links( 
        array(
            'base'      => str_replace( $big, '%#%', esc_url( get_pagenum_link( $big ) ) ),
            'format'    => '?paged=%#%',
            'current'   => $paged,
            'total'     => $query->max_num_pages,
            'prev_text' => '&laquo; Previous',
            'next_text' => 'Next &raquo;',
        ) 
    );

    return $pagination;

}

EDIT 2

Frm your comments, and as I have already stated, static front pages and single pages uses get_query_var( 'page' ) for pagination while all the other uses get_query_var( 'paged' ). I have updated all the code above with the following

if ( get_query_var('paged') ) {
    $paged = get_query_var('paged'); 
} elseif ( get_query_var('page') ) { 
    $paged = get_query_var('page'); 
} else { 
    $paged = 1; 
}

This will sort the problem with page and paged and make your shortcode and pagination work across all pages without any specific changes made to it

EDIT 3

Here is a sligtly modified version of the code by @ChipBennet which will sort the problem of /page/2

function home_pagination( $query = null ) 
{
    global $wp_rewrite;

    if ( get_query_var('paged') ) {
        $paged = get_query_var('paged'); 
    } elseif ( get_query_var('page') ) { 
        $paged = get_query_var('page'); 
    } else { 
        $paged = 1; 
    }


    $pagination = array(            
        'base'      => @add_query_arg( 'paged', '%#%' ),
        'format'    => '',
        'current'   => $paged,
        'total'     => $query->max_num_pages,
        'prev_text' => '&laquo; Previous',
        'next_text' => 'Next &raquo;',
    );

    if ( $wp_rewrite->using_permalinks() )
        $pagination['base'] = user_trailingslashit( trailingslashit( remove_query_arg( 's', get_pagenum_link( 1 ) ) ).'/%#%/', '' );

    if ( ! empty( $wp_query->query_vars['s'] ) )
        $pagination['add_args'] = array( 's' => get_query_var( 's' ) );

    return paginate_links( $pagination );
}

Related Posts:

  1. How can i retrieve default post per page value? from settings->reading. And total number of posts?
  2. Pagination with custom SQL query
  3. Pagination on a WP_query not showing navigation links
  4. How to paginate wordpress [gallery] shortcode?
  5. paginate_links ignore my format
  6. How to paginate attachments in a secondary query as gallery?
  7. Query causing load because of SQL_CALC_FOUND_ROWS post counting?
  8. Pagination with 5 posts per page
  9. pagination doesn’t show up for custom post type
  10. Pagination causes error 404 when used with front-page.php
  11. Paginated pages are showing correct content but pagination links are not
  12. Pagination wont work with search results template [duplicate]
  13. Pagination Not working on Home Page with 2 Query
  14. Best Practice For Querying Grandchildren?
  15. Pagination not working on static page
  16. ‘paged’ in wp_query doesn’t work
  17. Display different number of posts from one category on the different pages
  18. Pagination not working Search posts
  19. Pagination not working for category posts
  20. WP Query with offset breaks wp_pagenavi or any pagination
  21. Search – Ajax – Alter Query Parameters with Pagination
  22. Two queries on the same page with pagination
  23. Show single post then all posts (with pagination)
  24. Add custom search results to main WP search [duplicate]
  25. Pagination doesn’t work in custom page template [duplicate]
  26. WP_Query pagination not working in admin area
  27. WP_QUERY loop, offset in the arguments and the paginate_links – can these work together?
  28. Pagination working everywhere but the index page
  29. WP_Query ajax loader detect end of posts
  30. Storing query variable and then using wp_reset_query
  31. How to set pagination to work with ‘/page/’?
  32. Get pagination working for custom loops within page templates
  33. WP_Query Pagination on multiple-loop page breaks WP or doesn’t show up
  34. WordPress Pagination changes my template
  35. wp_query ‘s’, search filter with pagination is not working
  36. pagination with ‘no_found_rows’ => true,
  37. Custom Pagination Layout for Elementor widget
  38. WordPress pagination not working on template search.php
  39. Pagination links missing for first link (1) and previous button? How to get pagination links to work?
  40. Pagination outside of loop
  41. How to return a 404 when custom query matches nothing?
  42. Pretty urls for custom pagination
  43. Multisite pagination issue by multi query archive 404
  44. Custom Pagination in Shortcode with WP_Query
  45. Avoid repeated post on page 2 when excluding one on page 1
  46. Pagination for blog posts reloading same page [closed]
  47. Append URL query to next post link in custom query
  48. new WP_Query messes up pagination
  49. Pagination is not working with custom query inside a homepage template
  50. Display single most recent post in category on every page of category archive
  51. Include latest author posts with pagination in single template?
  52. Pagination works in custom query loop but it doesn’t work in shortcode
  53. Page navigation doesn’t seem to work when I add offset?
  54. Content not displaying on paginated page
  55. I am officially missing something about transient posts
  56. Adding pagination to sub-wp_query within a singular post page
  57. How to filter a static post page with ajax and $wp_query
  58. WP_Query and pagination AGAIN?
  59. WP_Query Pagination
  60. WP_Query, Paginate by Custom Field
  61. Reciving Error 404 blog/page/2/
  62. duplicated posts when using pagination
  63. wordpress pagination wont render on custom page template even though its right under the loop like the documentation says so
  64. How can I have sticky posts while ALSO showing posts from a specific category using one WP_Query?
  65. Pagination repeating posts on search results
  66. WP_query pagination on frontpage
  67. Pagination for Category does not work
  68. 404 page on custom search pagination
  69. Paging works correctly on local version, but not live?
  70. Pagination not working in custom loop WP_Query
  71. pagination functions are not working
  72. WordPress pagination not returning posts on second page
  73. Paginate nested query of child posts
  74. How to set up pagination for a custom loop on a global template (author.php, tag.php, archive.php?)
  75. 3 wp_query on one page with pagination for last query
  76. Custom pagination (Title, date and teaser)
  77. custom query – offset to pagination
  78. previous_posts_link not working in WordPress pagination
  79. Pagination not working with WP_QUERY
  80. Add pagination to table generated by wp_query
  81. WP_Query with meta_value_num and meta_query not paged correctly
  82. Pagination in custom query in a category page
  83. Pagination with WP_Query not working
  84. What is wrong with this pagination code?
  85. wp_query pagination links producing 404
  86. Can’t get pagination to work with this WP_Query loop
  87. Pagination in custom loop [duplicate]
  88. Why won’t my paged wp_query work? [duplicate]
  89. WP_Query breaks pagination
  90. Pagination doesn’t work for home page custom post type query
  91. Pagination in WP query with transient API
  92. paginate_links() with Custom Taxonomy
  93. Multiple loops on index page with sticky post and pagination
  94. Pagination problem with multiple loops on the same page
  95. Pagination not working in secondary query
  96. WP Paginate not working properly
  97. Show number of posts AND number on current page (cannot make it work)
  98. Search results stuck on page 1
  99. Pagination only showed when no category is set in wp_query
  100. taxonomy-{term}.php terms pagination returning 404 after a certain page

Leave a Comment

tech