c++ a heap has been corrupted error when running the program

I have not reviewed the whole code, but there are tools available that can help you in this situation that track the usage of memory and indicate if something went wrong. One example is valgrind that is at least available for Linux environments. Anyway, this tool allowed me to find at least one bug in your code as follows.

  1. Compile with debug information. If you are using gcc, use the -g command line flag e.g. g++ foo.cpp -g -o foo -std=gnu++11
  2. Run with valgrind valgrind ./foo
  3. Look at the output ==6423== Memcheck, a memory error detector ==6423== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al. ==6423== Using Valgrind-3.11.0 and LibVEX; rerun with -h for copyright info ==6423== Command: ./foo ==6423== please enter your team name sdfads please enter the number of the max players on your team 3 please enter the name of the player efwf please enter the num of the shirt 5 please enter the name of the player dsfdsa please enter the num of the shirt 3 Team name: sdfads Max Number of players in team: 3 Current number of players in team: 0 Team Players: Player name: efwf, Player shirt: 5 Player name: dsfdsa, Player shirt: 3 ==6423== Invalid write of size 8 ==6423== at 0x4011FF: getAllPlayersStartWithA(team_t*) (foo.cpp:155) ==6423== by 0x400C08: main (foo.cpp:38) ==6423== Address 0x5ab6668 is 0 bytes after a block of size 8 alloc'd ==6423== at 0x4C2E80F: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==6423== by 0x4011CC: getAllPlayersStartWithA(team_t*) (foo.cpp:151) ==6423== by 0x400C08: main (foo.cpp:38) ==6423== ==6423== ==6423== HEAP SUMMARY: ==6423== in use at exit: 72,719 bytes in 3 blocks ==6423== total heap usage: 8 allocs, 5 frees, 74,829 bytes allocated ==6423== ==6423== LEAK SUMMARY: ==6423== definitely lost: 15 bytes in 2 blocks ==6423== indirectly lost: 0 bytes in 0 blocks ==6423== possibly lost: 0 bytes in 0 blocks ==6423== still reachable: 72,704 bytes in 1 blocks ==6423== suppressed: 0 bytes in 0 blocks ==6423== Rerun with --leak-check=full to see details of leaked memory ==6423== ==6423== For counts of detected and suppressed errors, rerun with: -v ==6423== ERROR SUMMARY: 2 errors from 1 contexts (suppressed: 0 from 0)
  4. Apparently you have a problem in line 155 according to this output ==6423== Invalid write of size 8 ==6423== at 0x4011FF: getAllPlayersStartWithA(team_t*) (foo.cpp:155) And if we look closer, we see the following: player_t **p = new player_t*[sum + 1]; for (int i = 0; i < team->maxOfPlayers; i++) { p[i] = NULL; } You create an array of size sum+1, but iterate over it up to team->maxOfPlayers that might or might not be the same. This means you write to some memory outside of the array that you want to modify and therefore you write somewhere in the heap where you should not (leading to a heap corruption).

This is at least one problem. Repeat 1.-4. until valgrind has nothing else to complain about.

Related Posts:

  1. Pause Console in C++ program
  2. Why the switch statement cannot be applied on strings?
  3. How to dynamically allocate arrays in C++
  4. How to convert string to char array in C++?
  5. How can I convert a std::string to int?
  6. Why is “using namespace std;” considered bad practice?
  7. What is a lambda expression in C++11?
  8. How to convert string to char array in C++?
  9. ld: symbol(s) not found for architecture x86_64 error
  10. C++ string to double conversion
  11. How do I print out the contents of a vector?
  12. C++ for each, pulling from vector elements
  13. How do I erase an element from std::vector<> by index?
  14. Incomplete Type Is Not Allowed
  15. how to implement quick sort algorithm in C++
  16. C++ Vector of pointers
  17. How do I reverse a C++ vector?
  18. Is there a C++ decompiler?
  19. What is a dangling pointer?
  20. undefined reference to WinMain@16 (codeblocks)
  21. Why use ‘glad’ library for opengl initialization? [duplicate]
  22. What does `*&` in a function declaration mean?
  23. (->) arrow operator and (.) dot operator , class pointer
  24. How to reverse an std::string? [duplicate]
  25. Undefined reference to vtable
  26. In C++, what is a virtual base class?
  27. wntdll.pdb not loaded – Can’t see the exception
  28. Difference between const reference and normal parameter
  29. Why am I getting this redefinition of class error?
  30. error: redefinition of class
  31. How to convert a std::string to const char* or char*
  32. What is the difference between a static and const variable?
  33. What is move semantics?
  34. How to pass optional arguments to a method in C++?
  35. How to copy a string of std::string type in C++?
  36. C++ forbids converting a `string` constant to `char*` – Alphabets to Morse converting program
  37. What is activation record in the context of C and C++?
  38. Static array vs. dynamic array in C++
  39. C++ terminate called after throwing an instance of ‘std::out_of_range’ Simple Averaging code
  40. Error “C++ requires a type specifier for all declarations whilst defining methods”
  41. How to create a dynamically-allocated array of const objects, but have values assigned to them?
  42. Why doesn’t std::vector::push_front() exist?
  43. Fastest way to check if a file exist using standard C++/C++11,14,17/C?
  44. Invalid use of non-static member function c++
  45. C++ #include guards
  46. Is std::stoi actually safe to use?
  47. C++ forbids variable-size array
  48. Fill array with random numbers within a specified range (C++)
  49. Remove an array element and shift the remaining ones
  50. Right way to split an std::string into a vector
  51. Run C++ in command prompt – Windows
  52. pthread sleep linux
  53. 2D array vs array of arrays
  54. C++ error: definition of implicitly-declared
  55. Already defined in .obj – no double inclusions
  56. expected unqualified-id before string constant
  57. C++: Access violation writing location
  58. error: strcpy was not declared in this scope
  59. how to print a string to console in c++
  60. How to call a parent class function from derived class function?
  61. What is the most popular general purpose C++ framework?
  62. Adding message to assert
  63. c++ error: invalid types ‘int[int]’ for array subscript
  64. What are the different versions of exec used for in C and C++?
  65. C++ – include unistd.h: why not cunistd?
  66. Dynamically allocated string array, then change it’s value?
  67. Use the auto keyword in C++ STL
  68. c++ –
  69. C++ – statement cannot resolve address for overloaded function
  70. reading from stdin in c++
  71. Difference between pic Vs pie
  72. C++ Templates – LinkedList
  73. In C++ can constructor and destructor be inline functions?
  74. What’s the meaning of exception code “EXC_I386_GPFLT”?
  75. how to convert from int to char*?
  76. When is it safe to call this-> in constructor and destructor
  77. Stray ‘\342’ in C++ program
  78. gcc -g :what will happen
  79. How to automatically convert strongly typed enum into int?
  80. Function cannot be referenced as it is a deleted function
  81. Difference between and
  82. How to get size of dynamic array in C++ [duplicate]
  83. Creating folders in C++
  84. Unrecognizable template declaration/definition
  85. MSVCP120d.dll missing
  86. Modulo operator with negative values [duplicate]
  87. Finding the type of an object in C++
  88. C++ Simple Dice roll – how to return multiple different random numbers [duplicate]
  89. How can I get a file’s size in C++?
  90. Why can’t I make a vector of references?
  91. What does “-Wall” in “g++ -Wall test.cpp -o test” do?
  92. heap corruption detected | C++
  93. Update g++ but still old version
  94. module unsafe for SAFESEH image C++
  95. Why are there two different getline() functions (if indeed there are)?
  96. Whats the difference between UInt8 and uint8_t
  97. Struct with template variables in C++
  98. error: no member function declared in class
  99. Why does my program give “NULL used in arithmetic”
  100. no matching function to call for “getline”

Leave a Comment