Custom Post Type .current-menu-item not applying on Custom Post Type Archive Page

I found an answer by searching in similar posts and links. I added a line to fit my needs (I wanted to prevent my blog page to get highlited when on a custom post).See this line: unset($classes[array_search('current_page_parent',$classes)]);

Solution

function add_parent_url_menu_class( $classes = array(), $item = false ) {
  // Get current URL
  $current_url = current_url();

  // Get homepage URL
  $homepage_url = trailingslashit( get_bloginfo( 'url' ) );

  // Exclude 404 and homepage
  if( is_404() or $item->url == $homepage_url )
    return $classes;

  if ( get_post_type() == "artist" )
  {
    unset($classes[array_search('current_page_parent',$classes)]);
    if ( isset($item->url) )
      if ( strstr( $current_url, $item->url) )
        $classes[] = 'current-menu-item';
  }

  return $classes;
}

function current_url() {
  // Protocol
  $url = ( 'on' == $_SERVER['HTTPS'] ) ? 'https://' : 'http://';
  $url .= $_SERVER['SERVER_NAME'];

  // Port
  $url .= ( '80' == $_SERVER['SERVER_PORT'] ) ? '' : ':' . $_SERVER['SERVER_PORT'];
  $url .= $_SERVER['REQUEST_URI'];

  return trailingslashit( $url );
}
add_filter( 'nav_menu_css_class', 'add_parent_url_menu_class', 10, 3 );

Source

I am not a fan of this answer because it’s using the url to compare the element in the menu item, but this one will work fine for different menu IDs and is ok to use in a plugin. Hope it helps someone, lost a couple hours for something I consider a wordpress bug.

Related Posts:

  1. Query menu_order custom post types
  2. Clean URL permalink for custom post type
  3. Custom post type loops with different page templates
  4. wordpress custom post type remove duplicate menu item
  5. is_page_template not working as expected
  6. Custom Post Type Taxonomies -Posts not showing in Category or Tag pages
  7. Using wordpress template tags within an array
  8. How to display custom WP menus?
  9. How can I use archive-{post_type}.php theme template?
  10. Get custom post type categories to show up in menus
  11. Template code to split a post and print a custom field?
  12. Load info from customposttype into template page
  13. cpt not display inside nav menu
  14. Accessing download link from the loop with WP Download Manager Pro
  15. Why isn’t my custom post type using the corresponding custom post template?
  16. PHP Button Custom link [closed]
  17. Custom post type is_singular condtional not working when managing sidebar display
  18. tag.php doesn’t work with tags on a custom post type post?
  19. Assign single template to multiple custom post types?
  20. Add Content to Page without shortcodes
  21. Search that will look in custom field, post title and post content
  22. Custom taxonomy query for a custom post type
  23. Extend walker class with custom post types [closed]
  24. Date archives for custom post type
  25. If featured image doesn’t exist, show post content
  26. How do I redirect all 404 errors of a specific post type to another URL?
  27. How to save the checked boxes?
  28. Display posts of child category in template
  29. custom taxonomy – Template not working
  30. Error after deleting Custom Post Type with a function (no trash used)
  31. Append taxonomy terms as class names in markup?
  32. How do I provide a “show all posts” link in a paginated term archive?
  33. List terms from Custom Taxonomy
  34. WP_Query search posts by custom post type and custom taxonomy
  35. Loop through posts of a custom-post-type (event) and create .ics (iCal) file?
  36. how to get post slug from url in wordpress
  37. How to count custom post types with conditional operators
  38. Plugin templates in which directory
  39. Getting the URL of the parent page
  40. get_posts of Custom Post Type AND Custom Taxonomy
  41. Update menu when saving settings
  42. Replace text in post from cvs
  43. Get parent categories of custom post type
  44. Custom Taxonomy Navigation, with current menu items for children?
  45. Display posts from Custom Post Type in category page on front-end
  46. Use menus with anchors
  47. Create template for taxonomy results limited by Custom Post Type
  48. Querying both pages and posts
  49. Can one create multiple Custom Post Types with a for loop?
  50. How to add custom field to view-edit post type page
  51. Static apple-app-site-association file with wordpress
  52. Custom posts template page
  53. Add Previous/Next Buttons to CPT Single Pages Only
  54. Prevent custom post type from showing up in custom menus
  55. How do I add custom HTML to the content of an archive page’s posts?
  56. widget_posts_args not using the number of posts in widget
  57. How To Post WordPress Custom Post Types to Twitter via IFTTT
  58. Undefined $post in wp_query
  59. Apply template by path/slug related to custom post type?
  60. List latest post out of 2 custom post types
  61. WP not recognizing custom post type / template
  62. Create a custom taxonomy template that loops through child categories in term order?
  63. My template won’t apply, theme still fallback to index.php
  64. One Custom Post Type two different Templates
  65. On click some element i want to use some template
  66. Fetch data from two custom post types and create multidimensional array for output to html table
  67. Create a Dropdown Selector and Redirect for a Custom Taxonomy in WordPress?
  68. Create an user checklist system for a course plateform using ACF Pro and ACF Extended
  69. How to get the custom post data using post id in WordPress?
  70. See if the email exists or not
  71. On saving Post My permalink is updated and category is removed automatically which cause the 404
  72. Post template with breadcrumb needs to show page navigated from
  73. How to add specific terms in a custom post type?
  74. Limit custom post type to the authors only on front-end!
  75. WP_Query – How To Query Only Custom Posts With No Children of Their Own?
  76. programmatically generated custom post type is created more than once
  77. Create posts inside CPT post
  78. Taxonomies are not showing in the category dropdown
  79. Combine multiple separate lists into one
  80. Custom Taxonomy – fields
  81. Print post category name from a custom post type wordpress
  82. CPT post doesnt shows tags and category on backend admin page
  83. WordPress Custom Post Type – Post Attribute: Template. Template shows up and saves on the back end, but the default theme file is being rendered
  84. Custom post type with two templates
  85. Custom Post Type tag taxonomy “Page Not Found”
  86. DIVs not showing correctly on CPT?
  87. Create 2-layered dropdown menus for custom taxonomy and custom post type
  88. Get month and day from a Date Picker custom field
  89. Load different template for CPT (in loop) in my plugin?
  90. CPT Archive with parent page
  91. Select Menu for Custom post Type does not save
  92. is_singular won’t call my functions?
  93. Setting a Master Menu on a Custom Post Type
  94. Inserting two categories
  95. How to create custom page templates with default page layout framework?
  96. Comments are not working on Custom Post Type
  97. Send email on creation of custom post type and use get_post_meta()
  98. Menu Structure and URL structure, with Pages and Post-Type-Posts
  99. Just the First Metabox what saves the data!
  100. Why isn’t page attributes dropdown not showing up in a custom post type