Custom query using WP_Query is not working

Its not clear what the goal is here, but here are some suggestions:

  • In general, the pre_get_posts hook is not a good place to instantiate a secondary query to display HTML.

  • Your current setup will result in an infinite-loop, because when you instantiate WP_Query within the pre_get_posts callback, you will instantiate it recursively, until you reach the recursive limit with an error.

  • There are ways to instantiate a WP_Query within the pre_get_posts, by removing the callback after the first run, but I don’t think that’s what you’re after.

  • Remove this part from your function:

    if( is_home() && $query->is_main_query()){
    global $wp_query;

    and e.g. display the function in your home template instead. Note that $query is undefined in that line.

  • There’s also the handy get_template_part() if you want to resuse template partials.

  • You might also want to consider a proper function prefix, instead of my_, to avoid possible name collisions.

Related Posts:

  1. Nested meta_query with multiple relation keys
  2. numberposts? showposts? posts_per_page?
  3. How can I save an array from a random post sequence for later use?
  4. All-in-One Event Calendar: Custom Query – Getting each event Instance [closed]
  5. Is there an action/filter called when WP_Query->query is finished and assigns posts
  6. Limit search results to exact match
  7. Highlighting Sub topic in a post?
  8. Pagination Not working on Home Page with 2 Query
  9. Multiple keyword search
  10. Get number of comments after modifying comment query
  11. Show default content if custom WP_Query has no posts
  12. Include Sticky Posts with Custom Query
  13. $wpdb->insert inserting two rows in database
  14. Create unique page without header.php for json feed
  15. Sub-loop / nested loops Best Practices
  16. How to loop for every result found in the_content() when using the search query?
  17. Is there any advantage of using default WordPress Search instead of creating a custom one?
  18. Order By table field comment_status in WordPress > 4.0
  19. Clean up WordPress code that repeats
  20. How to optimize multiple WP_Query() calls on one page?
  21. Use post object from first query in second query
  22. Query to get siblings and parent page
  23. How to list custom fields as headers and list all pages sharing that custom field under it?
  24. Cutom wp_query for geolocation search, pagination not working
  25. Include data from custom table in WP_Query
  26. echo a specific meta_key queried through a custom post
  27. WP Group posts by year(desc) > month(desc) > date(asc)
  28. How to order posts on each different category?
  29. Get specific ACF key and value from all posts – no access to DB
  30. Orderby two meta fields not working
  31. Custom wp_query – I’m getting ‘all’ post, not the specific post in the query
  32. meta_query with array as value with multiple arrays
  33. Adding pagination to sub-wp_query within a singular post page
  34. Magazine style frontpage with multiple categories/loops and no duplicate posts
  35. How to make a query returning pages from multiple parents
  36. Prioritising and Ordering Posts By Category Name Using A Custom Loop
  37. Where is this query?
  38. How to use wp query in my custom page without including header and footer in wordpress
  39. Custom order revolution sliders post base slides as inserted in Specific Posts List field
  40. WP Query for all events prior to current date
  41. How to extend WP_query to a specific table?
  42. Display the search results like the original pages
  43. Multi line of $wpdb->query just run 1 time and end the loop right after
  44. Add to search posts query array with post IDS which will appear first
  45. Woocomerce – Order products by float attribute in archive pages
  46. Multiple values in WP_Query : category__and
  47. How to set up pagination for a custom loop on a global template (author.php, tag.php, archive.php?)
  48. Limit the number of posts from a specific category on index.php
  49. Get the type of an advanced custom field (ACF) in a WP_Query loop [closed]
  50. Switched from query_posts to wp_query, pagination no longer working
  51. WP_Query breaks pagination
  52. Pagination problem with multiple loops on the same page
  53. shortcode with $atts with strange results
  54. I need to get all categories from a WP_Query
  55. $wp_query->found_posts; returns zero
  56. Rewrite URL custom search query
  57. How to remove “MY WORDPRESS”” Label
  58. How could i add username field in WooCommerce
  59. Stomping WP_Query in author archive to facilitate pagination with custom queries
  60. How to make posts unqueryable/unpublish posts where ACF relationship field is an unpublished post? [closed]
  61. wp_query serialised array
  62. WP query is calling get_userdata and throws error [closed]
  63. Conditional operator OR not working with custom fields
  64. complex get_posts() query to select child pages
  65. Display if author page is author page of current user
  66. How to set up hierarchical relationships without using plugins / meta query
  67. Count posts per taxonomy else change taxonomy if less than x number
  68. How to add custom meta to ‘pre_get_terms’?
  69. How to add $args to any running wp_query from function.php?
  70. How do I check if an article is popular this week?
  71. WP Query ordering on a meta field for posts with a date in the future not ordering by datetime
  72. Merge 2 custom post type posts and taxonomy terms and sort ascending
  73. Single field to search for matches on post ID or meta values
  74. Tax Query only returns for the first of several terms
  75. Combine 2 arrays in a query parameter
  76. Pagination on template page for custom query redirecting to index.php
  77. Add ACF field in a query
  78. Set front_page programatically after user login via query, while leaving site option alone
  79. Can’t fetch Custom Post Type Data through Custom Query
  80. how to get Nearby zipcode
  81. Loop increase in while loop not working
  82. Wp-query Order By problem
  83. Create a loop on my pages with new “WP_Query”
  84. Get All posts by Tag_Id not working, query seems to contain extra term_taxonomy_id
  85. Getting rid of unwanted nonSQL syntax characters when debugging a query
  86. Is this meta query problematic?
  87. Get posts that do not have the same tags as current
  88. Which meta_query and post_content blend is better in WP_Query, performance wise?
  89. array of meta values using WP_User_Query
  90. queried_object using pre_get_posts gets notices and warning
  91. WP_Query object: what’s the difference between [query] and [query_vars]?
  92. Should $query-> be used with conditional tags?
  93. post_parent don’t work and return 0 page
  94. I need help using pre_get_comments to limit comments in the comments admin screen
  95. WP Query causing timeout
  96. Utilising an existing page while using the “s” query parameter
  97. Get user posts with custom WP_Query on author.php
  98. date_query in pre_get_posts out of memory
  99. posts archive page – closing WP_Query loop correctly [closed]
  100. How I can change the condition or compare operator for WP_Query in pre_get_posts
Hata!: SQLSTATE[HY000] [1045] Access denied for user 'divattrend_liink'@'localhost' (using password: YES)