Custom query vars filters problem with pagination

The problem is the pagination parameter in the URL:

<a href="https://wordpress.stackexchange.com/questions/298648/<?php echo (in_array($marca_term->slug, $marca_arg)) ? 
  esc_url(remove_query_arg("marca')) : esc_url(add_query_arg('marca', 
  "$marca_term->slug")); ?>">

Here we see that the marca term is being added and removed, but the pagination parameter isn’t, but that’s a part of the URL not a parameter

Instead, why not use the taxonomy archives and get_term_link? Then redirect if the marca parameter is present?

  • You could eliminate the pre_get_posts changes
  • the query var would no longer be necessary
  • the pagination issue would disappear
  • You can use taxonomy-brands.php in your theme
  • You already have archives for this at example.com/brands/*term_name* just waiting for a custom template

They’re already on your site, sitting there unused. Why rebuild something that’s already there? If you’re not keen on the URL you can change it in your taxonomy registration code via the rewrite option

Related Posts:

  1. Rewriting search and pagination base
  2. /page/2/ redirect to 404
  3. How to make a image-size selected by default in Media upload – WP v3.5
  4. Apply class to every paragraph that holds image?
  5. static variable loop not working in WordPress
  6. adding a filter to a shortcode?
  7. Set media upload attachment link to none and hide it in WP v3.5
  8. Build a content and excerpt grid loop with paging and options for # of posts
  9. Change the footer text on the login page
  10. add_filter to post-gallery and remove all ‘s?
  11. How to overwrite youtube embed?
  12. Check if page parent has certain template
  13. Change comments form title on a page by page basis
  14. Remove class that has been added by parent theme
  15. WooCommerce – Customer Order History Pagination
  16. Why does “get_option” pull in the older value in options.php, rather than the newer value, on submission of a form?
  17. How do I know what variables are passed in a filter/action and what their meaning is?
  18. Why do filters/actions require an argument count?
  19. Sorting Posts | Alphabetical Order
  20. Getting rid of role=”navigation” in the Home Page Pagination
  21. How to use return in my custom function instead of echo
  22. Use wp_get_recent_posts with search term
  23. Remove query string specific key value
  24. Run a filter when a walker runs
  25. Handling Body class based on Template
  26. Get_avatar filter?
  27. Add a class to the anchor tag on HTML5 gallery
  28. How can I remove a function that has been added to wordpress with add_filter?
  29. How to control WordPress image metadata (using Imagick)?
  30. How do I add custom bulk actions to multiple custom post types?
  31. Add data attribute to each li in menu
  32. How to prevent WP_Query function from returning all posts when empty?
  33. Display a specific category of products in shop page and disable code for specific actions
  34. Removing “wpautop” (auto tags) only on certain pages?
  35. WordPress Gravatar filter is removing my custom attributes
  36. Generating an nonce for Content Security Policy and all scripts – How to make it match/persist for each page load?
  37. Get users that likes the post
  38. Unique icons next to each WordPress menu item
  39. Remove echo from shortcode
  40. Redirect to another page using contact form 7? [closed]
  41. Alter required message using comment form api
  42. Override a function defined in wp-includes/comment-template.php
  43. Filtering a function’ output for a new continued function
  44. Pagination on Custom Post
  45. Prev/Next Links Broken on Static Front Page Pagination
  46. Deleting Certain terms from appearing on the front end as links
  47. Content filter won’t work
  48. the_posts_pagination() not working in wpquery
  49. Warning: in_array() null given in PHP function
  50. Upload multiple files in randomly generated folder using wp_upload_bits
  51. Create page template via functions.php?
  52. Add meta tags to a custom header
  53. WP_Query | IF within $args array | Help me only add specific arguments if the argument is not blank
  54. How to have different site identity logos on each page on Astra Theme [closed]
  55. change the default order of posts only for specific categories
  56. Get the name of menu item with wp_nav_menu
  57. How to add aria role and schema markup to custom walker container
  58. How to get post category list as select in front-end?
  59. Must filter functions receive all arguments passed to them?
  60. Displaying Event within two given time frames
  61. Remove Post if Advanced Custom Field is checked to fix paging
  62. How to add PHP pagination to wordpress
  63. How can I modify this code to make the search box include tags and meta
  64. User filter posts by year
  65. Output product category link from WP_Query
  66. Isn’t Returning Value While Using SELECT COUNT(*) FROM {$wpdb->prefix}
  67. How do I make these combination select filters work when only one dropdown is set? They work in WordPress 5.8.2 but don’t in 5.8.3
  68. How to exclude meta no index pages from wp_list_pages
  69. Load more posts using AJAX based on posts inside WP_Query
  70. WP query posts BUT show the most recent and one per author
  71. Ajax filter with loadmore button
  72. posts_per_page displays only 2 posts instead of 4 posts
  73. Delete post meta by serialized meta value
  74. How to bind each “the_content” elements to a custom variables
  75. Modify post image in full size
  76. WP_Query To Display Product Of Brand On Taxonomy Page
  77. How can I get my pagination loop to display the correct number of total pages?
  78. Custom Bulk Actions handler not firing
  79. How to generate customized filtered output for the gallery
  80. Add a leading zero to pagination
  81. My query keeps looping infinitely ! how to stop it?
  82. Apply filters when loading post via ajax
  83. Display Year and Month from custom field + Age Calculator
  84. insert thumbnail image from php script
  85. Weird Behaviour: Not all WordPress Posts appearing
  86. How to fix blank pagination links?
  87. How to get category pages to look like a certain archive page?
  88. Search box background on a different page template
  89. Display a list of users with avatar filterable with alphabets
  90. Keeping the previous get value and add another value when submitted
  91. Pagination not displaying
  92. Pagination in category.php not functioning
  93. How to modify this function to exclude also the post belonging to a specific category?
  94. AJAX: WordPress filters inside $html do not work as intended
  95. Assign new post author IF another user in custom field on post transition
  96. Blog Posts not sorted and pagination not adjusted after filtering some category
  97. Add attribute to featured image with filter (wp_get_attachment_image_attributes)
  98. How to pass value to add_filter wpcf7_form_tag from another function?
  99. Add text below WooCommerce short description if metabox value is true
  100. Is there a hook that I can use when a fatal error occurs?