Custom roles and capabilities media not work right

This happens because on every page load you call remove_role

As the docs note:

When a role is removed, the users who have this role lose all rights on the site.

Roles are not like post types, they exist in the database, and removing/adding a role updates the database. For that reason you shouldn’t add them on every page load, it’s better to do it on theme activation or plugin activation

Related Posts:

  1. Capability to edit own posts and not others
  2. Ability to only view (not edit) other user’s personal profile information
  3. WordPress SEO by Yoast: Hide Meta Boxes in Posts for Non-admins
  4. Modify custom Users Manage page
  5. How to not allow custom roles to edit published custom post types?
  6. How to change in customizer the “site identity” tab required capabilities
  7. User Roles Not Sticking
  8. Creating user relationships
  9. Define new user capability for custom post types?
  10. I want to submit multiple users if checkbox is checked
  11. How to add an extra button on woocommerce shop page and use it to send the product info with image in a mail? [closed]
  12. Custom Role with Own Page Edit Capability
  13. How to stop displaying the Id without losing the functionality
  14. how to make a custom field readonly or disabled by user role?
  15. Allow multisite admins only to create users with one specific user role?
  16. Hide content and functions from specific user roles
  17. How to determine which capability to use?
  18. Best practices to handle multilpe roles and capabilities?
  19. Show comments based on user role in front end
  20. Disallow “contributors” to edit their own posts once they’ve been set to “Pending Review”
  21. Users can only save their draft once before saving for revision
  22. Change the functionality of wordpress users module in admin
  23. What capability is required to view posts, scheduled in the future, by someone else?
  24. Security Issues with custom user role or changing core role capabilities?
  25. How to disable plugin capability : “create new category”
  26. Is there a flowchart for WordPress loading sequence?
  27. How do register_sidebar() and get_sidebar() work together?
  28. Groups of capabilities: users with multiple roles?
  29. How to customize the default HTML for WordPress Attachments
  30. Is it possible to change the attributes of a registered style or script before it fires?
  31. how to change “published date” format on edit.php (Posts page)?
  32. How to change submit button value in comment from “Post Comment” to “Send”
  33. Creating a searchable A-Z listing of hundreds of companies/services
  34. Show attribute description when filtering by that attribute
  35. Customize in category page
  36. How to get WordPress to accept the tag in articles (or other alternatives)
  37. Add custom column to Users admin panel with Types user custom fields?
  38. Let new user role to ‘edit_others_posts’ of other user role, not of its own type
  39. How do I change the default admin color scheme in MP6
  40. allow edit of custom post type but not regular posts?
  41. Users with custom roles can’t read each other’s comments
  42. woocommerce Add custom field set like billing fields
  43. How can a single line in a blog post take down my server?
  44. Calling a php file from a javascript file in wordpress
  45. Why is my Custom Post Type not showing up after adding capabilities?
  46. Adding a Table to the wordpress database
  47. how can I change the background color of all posts on my server?
  48. Auto redirect after session expire, but only for one user
  49. map_meta_cap woes
  50. Custom title, Bones theme
  51. Roles for Custom Post Types
  52. How to create a completely private wordpress with multiple membership levels
  53. Why do posts disappear from admin after upgrading from WP 2.7.1 to 3.0.1?
  54. How to change the category url jusy show /category/%category_id% in wordpress?
  55. custom meta box for page default template
  56. How can I display a PHP foreach loop’s answers by AJAX
  57. Add a role and give admin priviledges
  58. Child Theme with multiple css files
  59. “An automated WordPress update has failed to complete – please attempt the update again now”– But there is no .maintenance file
  60. How do I redirect a post url to a custom url?
  61. How to customize
  62. Why the css in twenteenfourteen-child theme take no effect?
  63. Determine if action was executed in functions
  64. Extending core class in plugin
  65. Restrict access to non-wordpress section of site with user roles?
  66. Is it possible to make wordpress LMS
  67. Saving contact form 7 data into custom Table
  68. User Capabilities are not available in WP REST permission callback?
  69. Hiding Short Description in Shop Page, WooCommerce
  70. theme customizer – can a single option pass multiple values?
  71. Separate header for static home page and posts page
  72. Media Upload not working after hiding some elements from functions.php
  73. Pagination with custom field
  74. Capabilities don’t add
  75. Customizing the gallery of the post correctly
  76. Will WordPress updates remove Gutenberg Additional Classes?
  77. WP_Query – sort the results by meta value custom attribute wocoomerce
  78. Allow a user or role to view drafts and previews, but not other admin privileges?
  79. Multiple header style under meta box
  80. Remove plugin settings from post creation page for a user role
  81. How can I create a Custom Page? (not a page template!!)
  82. Allowing custom role user to edit post assigned to them but don’t let them create new custom type post
  83. Add a custom intro page
  84. How to have differents sites share the same tables of DB?
  85. How to add particular attribute of product in shop as well as home page
  86. How to change custom link of subpages from of localhost to website
  87. Disabling user capability to edit_posts or delete_posts in the front-end
  88. Duplicate Header and Footer
  89. Custom login doesn’t stay
  90. Custom dropdown search form that allows users to select option B based from Option 1
  91. Smarter Document Management links between three WordPress sites sought
  92. data retrieval presents last set of data
  93. How to add a menu page for options in wordpress for user that has the role of vendor?
  94. How to get name and email value from a custom form and add it to campaign monitor subscriber list?
  95. Create a google friendly header with text and logo
  96. Custom Link In WordPress Media “Attachment Details” Upload Screen
  97. “Static” pages within a theme
  98. Custom WordPress SQL Query 4 posts per custom taxonomy
  99. Sync roles across several plugins
  100. How can I make a search term redirect to a page