Help solving t_echo php error while using echo do_shortcode

You’ve got an echo inside an echo.

Rewrite you code like this:

<?php echo do_shortcode('[orbit-slider category="' . get_post_meta($post->ID, "slide-category", true) . '"]'); ?>

This will concatenate things instead. and give you '[orbit-slider category="5"]' inside the do_shortcode() function.