Meta Box on Custom Post Type not saving

Hi @George Wiscombe:

So close, yet so far! (I know the pain, I’m there often. 🙂 You almost had it but are using the wrong hook to do the post meta update. Use the 'wp_insert_post_data' hook instead of the 'save_post' hook:

<?php
if (!class_exists('YourSite_Portfolio')) {
  class YourSite_Portfolio {
    static function on_load() {
      add_action('init',array(__CLASS__,'init'));
      add_action("admin_init",array(__CLASS__,'admin_init'));
      add_action('wp_insert_post_data',array(__CLASS__,'wp_insert_post_data'),10,2);
    }
    static function init() {
      register_post_type( 'portfolio',array(
        'label' => __('Portfolio'),
        'singular_label' => __('Portfolio'),
        'public' => true,
        'show_ui' => true,
        'menu_position' => 5,
        'capability_type' => 'page',
        'hierarchical' => false,
        'rewrite' => true,
        'show_in_nav_menus' => true,
        'supports' => array('title', 'editor', 'thumbnail', 'excerpt'),
        'has_archive' => true
      ));
      register_taxonomy( 'type', 'portfolio', array(
        'hierarchical' => false,
        'label' => __('Project Type'),
        'query_var' => 'type',
        'rewrite' => array('slug' => 'portfolio/type' )
      ));
    }
    static function admin_init(){
      add_meta_box('portfolio_text','Main Text',array(__CLASS__,'portfolio_options'),'portfolio','normal','high');
    }
    static function portfolio_options($post,$metabox) {
      $portfolio_text =  get_post_meta($post->ID,'portfolio_text',true);
    $html =<<<HTML
<textarea name="portfolio_text" cols="40" rows="1" style="width:98%; height:100px"/>{$portfolio_text}</textarea>
HTML;
      echo $html;
    }
    static function wp_insert_post_data($data,$postarr) {
      if ($postarr['post_type'] == 'portfolio') {
        update_post_meta($postarr['ID'], 'portfolio_text', $postarr['portfolio_text']);
      }
      return $data;
    }
  }
  YourSite_Portfolio::on_load();
}

The 'wp_insert_post_data' hook is where WordPress captures the values from the $_POST array; by the time you reach 'save_post' WordPress has reloaded the post and that’s why 'portfolio_text' empty when you are trying to save it.

Related Posts:

  1. Multiple Custom Metabox Help
  2. wp_dropdown_categories in custom post type with custom taxonomy
  3. How can I add a column/s to wp_posts table?
  4. Remove tabs from media uploader for a CPT
  5. Find callback function for custom taxonomy metabox
  6. Remove custom metaboxes from custom post type
  7. Add special meta box to custom post type
  8. Custom field values get deleted
  9. Priority of Meta Box for Custom Post Type
  10. Display metabox conditionally
  11. Using ‘strtotime’ function to convert a custom-meta-box to a date-stamp
  12. How to Change the Title of a Meta Box on a Specified Custom Post Type? [duplicate]
  13. How to save the checked boxes?
  14. Adding Custom Metaboxes to Custom Pages
  15. add_meta_box: Datepicker like the one for postdate?
  16. Save or update data when custom post published
  17. Custom metabox translation
  18. Custom Post Type Meta Boxes
  19. How to add multiple featured image in meta box in post editor?
  20. Formatting custom meta box date from YYYY/MM/DD to a more readable alternative
  21. Using WPAlchemy metabox values in another metabox
  22. Adding Meta Boxes while Registering a Post Type in a Class
  23. Dynamically add / duplicate custom meta in custom post types
  24. Custom Post Type Metabox – Not Saving
  25. How can I create a custom meta box to add an mp4 video to a page?
  26. List of Posts in a Custom Field
  27. Pull a post based on a meta value in a custom post type
  28. Change meta box when the page’s template is changed
  29. Cannot save Checkbox meta box value from a Custom Post Type
  30. Undefined Variable – Custom Post Type Meta
  31. Add Standard Page Attributes Metabox for Page Parent
  32. Custom date changer post_date => future – missed schedule error
  33. Found 2 elements with non-unique id (#_ajax_nonce) and (#_wpnonce)
  34. Metabox not show in categories custom post type cmb2
  35. Repeatable Fields Metabox with Textarea (or wp_editor)
  36. How to use TinyMCE Editor for one of my custom post meta field?
  37. Display correctly using metabox.io
  38. pre_get_posts for custom page builder meta box
  39. How to make custom taxonomy into drop down select in a custom metabox
  40. Translating custom post type metaboxes [closed]
  41. How to Add multiple instance of meta box to custom post type
  42. Using POST method in meta box, no results
  43. Global custom meta box
  44. Sizing textarea field in custom metabox
  45. Add a custom meta box for client to order CPT posts how they want
  46. Use remove_meta_box conditionally on custom post type
  47. create custom meta box with default value
  48. Issue on Working with Metabox – Checkbox to enable Sale Items
  49. wysiwyg editor don´t export paragraph
  50. How to make a meta box?
  51. Forms and WordPress Nonce
  52. Why do I have to press the “Update” button twice to save my meta box values?
  53. Inefficient Query Confusion
  54. Prevent custom post type from showing up in custom menus
  55. link featured image to external link
  56. Odd behaviour for the update button when displaying a WP_List_Table
  57. Creating alternate meta box context locations
  58. Showing a meta box in a custom post type on a page
  59. Having Issue on Getting Metabox Checkbox Value
  60. Custom meta box in custom post type not working
  61. Multiple wp_editor instances in custom post type using Ajax
  62. WP_Meta_Query object with conditionals
  63. I can’t connect my custom jquery to wp admin
  64. Saving meta box data?
  65. Updating post content and custom fields in edit post screen
  66. Add a class to post_class if more than one post shares same meta_value_num
  67. Function to return values from metabox
  68. Invalid file type when using wp_upload_bits to upload PDF to a custom post type
  69. Add a meta field to the list of results for a custom post type
  70. Metabox does not show in custom post type
  71. One Custom Post Type two different Templates
  72. Create a custom post type based on ‘Post’
  73. How do you make relational post types in WordPress? [duplicate]
  74. Include a metabox in the ‘home’ screen of a custom post type? If not, then the dashboard page?
  75. Placing Admin Post Metaboxes in Tabs
  76. Wp Meta Query does not work while simple Query Works
  77. create a “add icon” field in taxonomies page
  78. How to get custom post type with dynamic ID
  79. Custom metabox with image gallery upload that won’t attach images to post
  80. Problem with multi checkboxes value in metabox?
  81. Wp Query sort order from custom MetaBox
  82. How to retrieve custom post type permalink in another cpt?
  83. Custom meta box in editor of custom post type not working
  84. do action inside a class is not working
  85. How to add a custom meta box below publish box in CPT that is like publish meta box and can contains html?
  86. Search form to find custom meta box generated data
  87. Edit post meta direct from post.php?
  88. How to Arrange Support => Thumbnail
  89. Add different meta box based on taxonomy
  90. Custom metabox value not saving
  91. Yearly Archive from a custom date metabox (Event Start Date)
  92. Need to build custom metabox select prev posts by category
  93. Customized featured image doesn’t refresh in post admin metabox after upload/insert
  94. Saving custom metabox data with a twist
  95. loop through custom post-type with two meta_keys
  96. Custom Post Type + Custom Meta Query Not Showing 2012 Posts
  97. CPT Template Option to Top
  98. Use a Variable in update_post_meta as the $meta_key
  99. Canot save post if any meta box was empty
  100. Multiple posts selection [closed]