save_post only saves meta data on second save

Did you try removing the IF statements and use save_post hook instead of save_post_listing to see if an IF statement is blocking the wp_set_post_terms?

Also try wp_set_object_terms instead of wp_set_post_terms.

Furthermore, if you can make sure it has to do with the
if(get_post_meta($post_id, 'wpcf-proprty_online', true) == 'y') statement, then this post_meta has not been updated before you are execusting this function. So why not update it within this function to make sure the value == ‘n’ or ‘y’.

update_post_meta( $post_id, 'wpcf-proprty_online', $_POST['the_name_of_yr_field'] );

Related Posts:

  1. Check for update vs new post on save_post action
  2. How to avoid infinite loop in save_post callback
  3. $update is always true in save_post
  4. Action hook ‘save_post’ triggered when deleting posts
  5. get post meta before it is updated (during SAVE_POST)
  6. save_post action firing before I publish / save the post
  7. save_post action only when creating a new post
  8. Check if value has changed on save_post
  9. Minimum Word Count Before A Post Can Be Made Pending Review
  10. update_post_meta() not working in save_post
  11. How do I save each option in a multiple select menu as it’s own meta_key + meta_value pair?
  12. Update post on save
  13. Post meta checkbox becomes unchecked occasionally
  14. Return code from save_post action?
  15. update_post_meta not working in save_post
  16. Get Post ID with insert/edit link
  17. How to manage saving custom field from Quick edit and Post Save using save_post action hook without colliding each other?
  18. Why save_post_$(custom_post_type) is fired even if I am not already saving a post?
  19. Set the value of custom field when post is published or updated
  20. pass error to admin_notices on “quick edit”/save_post action
  21. save_post requiere at least one uploaded file to be published
  22. Get $_POST & $_REQUEST values before adding/updating post
  23. How can I create a new user account while creating a new post, and then set that new user as the author of that new post?
  24. Validate post checking if child term is assigned
  25. Clear cache on post of one type when something happens to post of other type
  26. Why not fire the save_post event?
  27. Compare custom taxonomies of updated post (or new post) [Updated with progress]
  28. WordPress 4.9.8 doesn’t save if content has style=”
  29. Reset all transients on post or page save
  30. Using PODS data with save_post
  31. Cant’t delete my custom posts
  32. where does this $post_id come from?
  33. Update current WP post every 3 minutes [closed]
  34. Changing new post to “pending” on publish – but “Publish failed” – why?
  35. update_post_meta not working in foreach
  36. Save post in another table
  37. Strange bug on post/page save
  38. draft_to_pending action doesn’t seem to fire
  39. What action to use for when a post is saved / published, with a caveat
  40. Custom wp_editor doesn’t update post_content
  41. Save custom value to main content of post
  42. Check for page template on save_post hook
  43. Access NEW/UPDATED post values in save_post() callback function
  44. save button grayed out randomly
  45. Post editor doesn’t save embed media [closed]
  46. How to get a post meta value and pass that to update_option when a post is created or updated?
  47. WordPress save meta data : Displaying the word Array when selected
  48. Save current post using custom save button
  49. Connection Reset on post/page save
  50. Meta data not saved on save_post
  51. Insert/Update DB table when making new post or update older one
  52. Prevent Page/Post From Being Created based on Pages/Posts per User per Time Unit
  53. How to debug | Some times the “Save Draft” button seems to spin but does not actually save
  54. My custom title gets duplicated at every save or post update
  55. Use save_post to generate file on wordpress
  56. Detect, if post is saved manually or programmatically in save_post-hook
  57. Set custom messages for post update/save
  58. save_post + insert_post = infinite loop
  59. How to stop a user from updating the post date
  60. Why can’t I hook into save_posts after admin_init?
  61. How can I pass $post object to ‘save_post’ add_action?
  62. Returning ACF custom field from publish_post
  63. Post Auto Draft Issue
  64. publish_post conflicts with save_post
  65. WordPress as a web app – always auto-save post and meta data
  66. save_post_{CPT} not updating the ‘sticky_posts’ option
  67. Write automatic title at save_post (infinite loop)
  68. How to get updated data when save_post triggers?
  69. How to save post change url youtube link?
  70. Publish/Update post is changing image links from file url to post url
  71. How can I remove the kses filters when saving a specific post type ? (it breaks my JSON)
  72. Custom Taxonomy terms aren’t getting referenced or saved in Quick Edit or Bulk Edit, only on Single product page?
  73. Troubles with acf/save_post and WP_Query
  74. Set default value field meta_Value [closed]
  75. Saving Custom Field Data before Publish
  76. Removing Uncategorized on post save if other category present?
  77. Conditional for autosave or auto draft?
  78. Custom Post Meta from custom metaboxes is randomly being deleted
  79. save_post action doesn’t passing post id to my function as argument
  80. Migrating from metaboxes to wp_editor()
  81. How check if a post is saved from backend or frontend?
  82. Change post author without using wp_update_post()
  83. Can’t add_action to ‘save_post’ and get it to fire
  84. Help using acf/save_post hook to connect to Untappd API and update_field [closed]
  85. Secure way to use name_save_pre?
  86. unable to save custom taxonomy terms in a custom-built metabox in wp-admin
  87. Is it possible to detect if a POST action is for a “Save Post” before the save_post action?
  88. Add action save post when create and publish
  89. Exclude URL’s from sanitize_html_classes
  90. Issue Saving Posts That Contain Shortcode
  91. save_post() on Menu Save
  92. wp_insert_post inside save_post adds wrong metadata to inserted post
  93. Custom post type meta fields missing on save_post_type
  94. generate random slug when adding taxonomy
  95. save_post affect creation and deletion
  96. Get Post ID in Admin Edit screen otherwise generate it?
  97. Meta Box – Javascript Datatable
  98. get categories the post was in and just been removed from
  99. Function that get ACF fields value before saving
  100. save post running twice and creating two database entries – how do I disable this?