No. Keep in mind that the code sniffer is a limited utility operating on very simplistic parsing of the PHP code and has very little contextual knowledge. Therefor, you should use it as an advisory, a tool that should direct you to give a second thought to a part of your code, and not as … Read more
If I understand your question, the race condition you describe between WordPress knowing the transaction was “complete” and the user returning to your site is the problem. Regarding a potential solution, what about changing the way you’re approaching this such that this race condition is accepted as a real possibility rather than something that you … Read more
first, you should use the proper filter and method to add query vars and rewrite rules and not manipulate the globals directly. the other issue I believe is your regex pattern, this is working for me: add_filter( ‘query_vars’, ‘wpa59404_query_vars’ ); function wpa59404_query_vars($query_vars){ $query_vars[] = ‘update_slug’; return $query_vars; } add_action( ‘init’, ‘wpa59404_rewrites’ ); function wpa59404_rewrites(){ add_rewrite_rule( … Read more
When you redirect the user to the admin dashboard pass on a GET variable named “success_notice”, for example. So you get a URL like this: /wp-admin/index.php?success_notice=1. With that setup, just add the code that shows the success message on the dashboard only if that GET variable is set. add_action(‘admin_notices’, ‘wpse75629_admin_notice’); function wpse75629_admin_notice() { global $pagenow; … Read more
Twice edited according to kaiser’s suggestions, unsecure version removed. <?php function my_email_friend($post_id = ”) { // get post object $post = get_post($post_id); // get post content $content = $post->post_content; // if @David exists if( 0 !== preg_match(‘/(@\w)/’, $content, $matches) ) $friend_display_name_like=”%” . like_escape($matches[0]) . ‘%’; else return; // do nothing if no matches global $wpdb; … Read more
At a first glance it makes sense, but… When exactly would that function be used? When user opens post editor, you can easily hook to that action and set the lock. But when would you remove it? After saving? No – user is still editing, so the lock should be on. It should be removed … Read more
A very helpful question, I think. There are two plugins, for the discussions let’s say: ToBeDeprecated Plugin, and ToBeUplifted Plugin There could be many ways, but these are the points that come to my mind first: Before the Upgrade Seemless Migration In the code of the ToBeUplifted plugin, you should ensure a seamless migration process … Read more
Turn off WP_DEBUG because it overwrite your ini_set.
This is more of a JavaScript the A WordPress Question but anyway, You can use the JavaScript onbeforeunload event something like: <script type=”text/javascript”> old = window.onbeforeunload; window.onbeforeunload = MyOnExit; function MyOnExit(){ //do your stuff here return old(); } </script>
Class names are case insensitive in PHP (with one exception), so that should not be a problem. Accessing your main plugin instance for a class is possible with a static method get_instance() (example). You don’t have to build a Singleton for that. And it should not break backwards-compatibility. If you had public methods in your … Read more