Should I ask a theme developer to use locate_template rather than require_once

Generally speaking, Child Themes were originally intended to be able to do two things:

  1. Override parent Theme CSS
  2. Override parent Theme template files

I doubt that the Theme developer intends for the /function-includes/theme-functions.php file to be overridden by a Child Theme. Functional files are usually a core component of the Theme, and allowing a Child Theme to override them wholesale would introduce serious development complexity into the Theme.

Rather than ask for a functional file to be able to be overridden by a Child Theme, I would instead ask the developer to make custom function output filterable, or (where appropriate), to make some custom functions pluggable (by far, I prefer filterable function output to pluggable functions).