Swapping current old site to new WordPress site – need to check I’m doing it right

I’d do it even simpler. Most hosting places allow you to specify where the root folder of your domain is. Just change that location, and the new WP site is available.

You shouldn’t need to change anything; use the standard WP htaccess, and leave the wp-config.php settings alone.

I use a standard procedure of my own to move a site from a testing place to a new home (the new live site). It has worked for me much better than the backup/restore/move plugins. Takes a bit of effort, but has always worked well for me. You’ll find it here: https://securitydawg.com/moving-a-wordpress-site/

There are other places that you can find ‘moving’ instructions; the googles will help you there. But I’ve used my process several times, and it has worked well for me.