C++ Array of pointers: delete or delete []?

delete[] monsters;

Is incorrect because monsters isn’t a pointer to a dynamically allocated array, it is an array of pointers. As a class member it will be destroyed automatically when the class instance is destroyed.

Your other implementation is the correct one as the pointers in the array do point to dynamically allocated Monster objects.

Note that with your current memory allocation strategy you probably want to declare your own copy constructor and copy-assignment operator so that unintentional copying doesn’t cause double deletes. (If you you want to prevent copying you could declare them as private and not actually implement them.)

Related Posts:

  1. Return array in a function
  2. Passing a 2D array to a C++ function
  3. How to create a dynamically-allocated array of const objects, but have values assigned to them?
  4. How to make an array with a dynamic size? General usage of dynamic arrays (maybe pointers too)?
  5. C++: Expression must have a constant value when declaring array inside function
  6. Delete 2D array C++
  7. C++ pass an array by reference
  8. C++ correct way to return pointer to array from function
  9. Warning: comparison of distinct pointer types
  10. Is C++ Array passed by reference or by pointer?
  11. Array of Linked Lists C++
  12. Is “delete this” allowed in C++?
  13. How to dynamically allocate arrays in C++
  14. How to dynamically allocate arrays in C++
  15. What are the differences between a pointer variable and a reference variable in C++?
  16. How do I find the length of an array?
  17. Initializing an array of objects
  18. Passing an array by reference
  19. Regular cast vs. static_cast vs. dynamic_cast
  20. What does “dereferencing” a pointer mean?
  21. Meaning of = delete after function declaration
  22. What is a char*?
  23. Passing an array by reference
  24. What exactly is nullptr?
  25. What is the array form of ‘delete’?
  26. Use new operator to initialise an array
  27. What is a dangling pointer?
  28. What does `*&` in a function declaration mean?
  29. (->) arrow operator and (.) dot operator , class pointer
  30. lvalue required as left operand of assignment – Array
  31. What is uintptr_t data type
  32. What is the difference between const int*, const int * const, and int const *?
  33. C++ – No matching member function for call to ‘push_back’
  34. What is uintptr_t data type
  35. What does int & mean
  36. What is the difference between const int*, const int * const, and int const *?
  37. Is there a function to copy an array in C/C++?
  38. Cleanest way to copy a constant size array in c++11
  39. Reverse Contents in Array
  40. warning: ISO C++ forbids variable length array
  41. c++ array – expression must have a constant value
  42. Can’t resolve Error: indirection requires pointer operand (‘int’ invalid)
  43. Static array vs. dynamic array in C++
  44. C++ delete vector, objects, free memory
  45. How to access the contents of a vector from a pointer to the vector in C++?
  46. Fill array with random numbers within a specified range (C++)
  47. Remove an array element and shift the remaining ones
  48. Deleting a dynamically allocated 2D array
  49. How to add element to C++ array?
  50. How to find the size of an int[]?
  51. What does int & mean
  52. splitting a string into an array in C++ without using vector
  53. What’s the syntax for declaring an array of function pointers without using a separate typedef?
  54. Printing an array in C++?
  55. Sorting Linked List C++ with pointers
  56. Is the sizeof(some pointer) always equal to four?
  57. How do you initialise a dynamic array in C++?
  58. C++ array assign error: invalid array assignment
  59. C++ Expression must have pointer-to-object type
  60. C++ strings and pointers
  61. How to initialize a vector of pointers
  62. What is the use of intptr_t?
  63. How to add element to C++ array?
  64. Reading from .txt file into two dimensional array in c++
  65. how to initialize an empty integer array in c++
  66. C++ – Assigning null to a std::string
  67. Check if C++ Array is Null
  68. Correct way to work with vector of arrays
  69. Resizing dynamic array in c++
  70. C++ Initializing a Global Array
  71. Comparing the values of char arrays in C++
  72. Dynamically allocated string array, then change it’s value?
  73. error: invalid initialization of non-const reference of type ‘int&’ from an rvalue of type ‘int’
  74. Reference to non-static member function must be called
  75. How can I assign an array from an initializer list?
  76. What’s the difference between * and & in C?
  77. creating an array of structs in c++
  78. Reading data from file into an array
  79. How to read lines of text from file and put them into an array
  80. Why can’t we pass arrays to function by value?
  81. How to memset char array with null terminating character?
  82. Function stoi not declared
  83. creating an array of structs in c++
  84. Why should I use a pointer rather than the object itself?
  85. too many initializers for ‘int [0]’ c++
  86. Function stoi not declared
  87. C++ 2d char array to string
  88. Using cin for char array
  89. Initializing pointers in C++
  90. Using cin to input a single letter into a char
  91. Different ways to deallocate an array – c++
  92. Difference between function arguments declared with & and * in C++
  93. Difference between the int * i and int** i
  94. set head to NULL (‘NULL’ : undeclared identifier)
  95. What is a `char*`?
  96. clearing a vector of pointers [duplicate]
  97. C++ Swapping Pointers
  98. Is it still safe to delete nullptr in c++0x?
  99. Differences between unique_ptr and shared_ptr
  100. C++ float array initialization 

Leave a Comment