Custom Post Type Loop within Shortcode

Notice: Trying to get property of non-object

Would indciate that $post has no scope inside your function. One simple solution here would be to globalise $post so it has scope, effectively fixing the error.

However, whenever you create a query, or run the loop and call the_post method this gives you access to the WordPress template tags.

Rather then put in global statements you could call get_the_ID() which should of course contain the given post’s id(ie. the current post for that iteration of the loop).

Update your problem line to read..

$custom = get_post_custom( get_the_ID() );

And that should clear up the problem, of course noting giving $post scope inside the function would also work, it just wouldn’t look as poetic!.. 😉

Small side question back to the asker, what are you looking for when you call get_post_custom, are you checking for some particular meta keys, or looping over every meta item you find? There may be some room for improvement there(if you’re interested).

Related Posts:

  1. Display all posts in a custom post type, grouped by a custom taxonomy
  2. Should unaltered default loop/query return a list of custom posts belonging to a custom taxonomy?
  3. Query for posts in 2 taxonomies
  4. Separate Posts and Custom Post Type in Custom Taxonomy archive template
  5. Why does using WP_Query inside a shortcode in an elementor page cause the arguments for WP_Query to get malformed?
  6. Is it possible to create a shortcode that will query a post based on taxonomies?
  7. wp_query to find posts by year and month
  8. Filter by custom taxonomy slug on a custom post type
  9. Display CPT posts based on specific taxonomy
  10. Custom loop with multiple taxonomy queries
  11. What’s the WP way to load remaining custom posts?
  12. display posts of custom post type with custom taxonomy
  13. List all Custom Post Type posts excluding certain Taxnomy term
  14. Cant’ Display Custom Post Type Title Base on Tax Terms
  15. Loop for custom-post-type comparing taxonomy terms for “related” posts?
  16. Multiple custom post type queries causing wrong post types to be grabbed in taxonomy + single templates?
  17. Query for specific taxonomy that executes a particular loop depending on volume of posts?
  18. What is the most efficient way to execute recursive complex queries?
  19. Get Posts List of Current Selected Custom Taxonomy in Shortcode
  20. Loop with Custom Post Type and Taxonomies
  21. Shortcode display CPT Query only showing 1 post?
  22. Post data in separate divs with incrementing class using WP_Query
  23. Catergory args causing loop not to show
  24. display custom post type from register taxonomy
  25. Complex Custom Loop with Includes
  26. Counting Posts of a Given Post Type Having a Specific Taxonomy?
  27. Displaying Posts Related to Other Posts by a Taxonomy Term?
  28. Querying Posts by Taxonomy From Alternate Network Site
  29. WP_Query on custom post type not displaying, multiple loops & get_template_part
  30. Conditional two level dropdown filter for custom post type
  31. Show all custom post type posts sorted by custom taxonomy then by another custom taxonomy
  32. How to create posts (not post template) to be displayed on projects page?
  33. WP_Query post at custom position
  34. 404 error PageNavi custom type taxonomy | wordpress
  35. IF statement in a do_shortcode
  36. Paginated Taxonomy Term Archive including one post per term
  37. How to dynamically build a multiple taxonomy query loop within a post type’s single loop?
  38. Get custom posts with certain ids in a custom loop using a shortcode
  39. get_template_part for each level of taxonomy term
  40. Query custom post type in the loop
  41. Loop through Custom Post Type, and then show children within each iteration
  42. Very Slow Page – How to Optimize # of Queries?
  43. WordPress Genesis custom taxonomy archive shows 3 repeats of each post
  44. Am unable to reset a query properly
  45. How to make sure content doesn’t display if selection is empty
  46. Archive for custom taxonomy lists all posts instead of current taxonomy
  47. Get next and previous 3 posts in a term in single post page
  48. Get custom post type list for every category shortcode
  49. Display all taxonomy terms, add class if term applies to current post
  50. Custom WP Query on custom meta and sort by multiple meta keys value
  51. WP Query with categories only shows one post and ignores the category
  52. Add Custom Post Type of specific Custom Taxonomy to regularly blog loop
  53. Only show posts with date of today or in the future (i.e don’t show past posts)?
  54. WP Query post__in not returning correct results
  55. Sort posts in loop by the WooCommerce Membership of the author
  56. WordPress wp_query() basic question about args
  57. get_post_meta is not working inside shortcode
  58. Custom post type, custom taxonomy, query posts only from taxonomy (children of)
  59. get_pagination not working on a custom post type query (using WP_Query)
  60. WP_Query with custom post type ID
  61. How to get the post terms from a child taxonomy
  62. Custom Post Type and Taxonomy Loop Output Is Wrong
  63. postsperpage value not being applied
  64. Exclude latest post from WP_Query taxonomy term loop
  65. foreach loop inside the loop creating duplicates in output
  66. Shortcode / WP_Query in post changes context
  67. How to fetch posts that are stored in the different table than (default) wp_posts?
  68. WP_Query order custom post type with certain meta key value by post modified date
  69. How do i display post from a taxonomy term?
  70. Display featured posts for a custom post type by taxonomy
  71. How to display list of custom post taxonomy terms and their posts (if any)?
  72. display post count in archive page that have relation with another taxonomy term
  73. Shortcode with loop stacks output
  74. How to search through all child taxonomies using WP_Query?
  75. Custom meta fields not showing up in WP_Response Object via custom endpoint
  76. posts_per_page is not working by term
  77. Wrapping an unknown amount of posts inside separate HTML Containers during WP_Query loop
  78. % encoded URL giving 404 error in WordPress
  79. CPT: multiple loops with different terms
  80. sorting in wp query based on custom field value
  81. Add active class to foundation 6 tabs while looping categories
  82. Why get_posts() returns empty array while I am trying to get posts from some specific taxonomies and work properly with others?
  83. WordPress loop add heading before first of type
  84. Only show current category post
  85. Looping through custom taxonomy in one template
  86. get_post_meta for Custom Post Type ( CPT )
  87. WordPress query posts by custom post type not workng
  88. Get posts of an specific term of a custom taxonomy
  89. Checking Taxonomy Terms for a Custom Post Type With get_the_terms Not Working
  90. WP_Query for CPT with filter by another WP_Query
  91. Is it possible to add query parameters on the archive page?
  92. Plugin Error on activating
  93. How to query posts by meta keys AND under specific category?
  94. How can I pull information from my loop and divide them seperately?
  95. Storing/querying custom date data
  96. Fallback if statement based on the number filtered from it
  97. Fourth page of custom post type archive page does not exist
  98. Query custom post type and group by taxonomy
  99. Create a WordPress loop that shows posts from a custom post type + filters the posts by taxonomies while hiding empty taxonomies
  100. Add Custom Taxonomy Terms as CSS Classes for CPT Posts in an Elementor Loop Item Template