How can I fix this code [duplicate]

prepare has always required two arguments, it just didn’t throw an error when used incorrectly until 3.5.

Basically, the use of prepare in this case is not doing anything. Since you’re not passing potentially unsafe data to the query, you can remove it entirely to get rid of the error and just pass your query directly to get_var.

$olddomain = $this->db->get_var( "SELECT option_value FROM {$this->db->options} WHERE option_name="siteurl" LIMIT 1" );

See the entry in wpdb Protect Queries Against SQL Injection Attacks for correct use of prepare.

Related Posts:

  1. When to use Exceptions vs Error Objects vs just plain false/null
  2. How to check if image is already stored in a site’s post database? (network)
  3. PHP Catchable fatal error: Object of class WP_Error could not be converted to string
  4. Customize default settings on new sites on multisite
  5. Sorting list of sites from multisite network using wp_get_sites
  6. Integrating WordPress to my website, while keeping my own authentication system
  7. WordPress “Link has expired” error on updating posts
  8. Notice: Constant already defined in wp-config.php on (non-existent) line?
  9. error_log is not working as expected in functions.php file
  10. “Can’t use function return value in write context” error
  11. Error when requesting password reset email – wp authentication
  12. “Notice: Undefined variable: content” is showing [closed]
  13. Can WordPress email the admin about PHP errors, while hiding them from the site?
  14. White Screen of Death – wp-admin
  15. WordPress (3.9.1) MultiSite Permissions. Is chown the answer?
  16. WordPress 5 WP REST routes – No errors
  17. wordpress media library new uploads don’t write to database
  18. WordPress Script stops suddenly
  19. A non-numeric value encountered in /wp-includes/functions.php on line 68
  20. How to call plugin function per site in a multisite?
  21. WordPress returns “The link you followed has expired” error page whenever I add a new site, add a user etc
  22. Make a list of sites for each user in WPMU – switch_to_blog (display in SITE_ID: 1)
  23. Getting error when using wp_insert_post()
  24. Headers already sent in Pluggable.php / homepage and wp-login error
  25. “Undefined index” error when saving empty array with checkboxes
  26. Moving code from theme header to functions.php
  27. Count posts on multisite with blog id
  28. Warning: Illegal string offset on theme options page [closed]
  29. How do I display offsite database info on my wordpress site?
  30. PHP if statement works in template files, but not header
  31. Timthumb.php image gallery not working on Multisite WordPress
  32. Find Site ID From WP_Post
  33. List all blogs, but exclude the main site
  34. PHP-warning in post-template.php and no loading content on pages
  35. Parse error: syntax error, unexpected ‘}’ [closed]
  36. Array to string conversion error in PHP 7.2 when returning user role as class
  37. PHP E_WARNING being shown despite php.ini [closed]
  38. Known Issues in WordPress When Upgrading PHP to ver 7
  39. can’t get errors
  40. Cannot load media and I get “PHP Warning: Invalid argument supplied for foreach(“
  41. Is it legal to redefine wp_password_change_notification in a mu plugin?
  42. Fatal Error wp-settings.php on line 119
  43. Trying to display terms from custom taxonomy within function
  44. Too many errors on log
  45. Programmatically revert to backup .htaccess a possibility?
  46. Prevent post from being published and show error
  47. How to sort posts by active category in WordPress?
  48. wordprees multi-site in user panel add filter
  49. bp-custom.php is not working on a WordPress multisite environment. how to fix it?
  50. WordPress Multisite login_redirect to primary blog and specific page based on role
  51. How can I update WordPress plugins or WordPress itself in all server?
  52. Can’t log in to WordPress wp-admin after adding code to functions.php
  53. White screen after migrating site, but wp-admin works fine. Disabling all plugins, applying default theme and enabling debug mode does nothing
  54. PHP Warning: mysqli_query(): after updating my websites php from 5.6 to 7.2
  55. WordPress Bad Request Error 400
  56. Internal Server Errors – Moving working multi-site install to my localhost
  57. HELP: cannot log into wordpress. PHP error
  58. Why am I getting syntax error, unexpected ‘endwhile’ (T_ENDWHILE) on single.php
  59. The link you followed has expired. Please try again
  60. PHP error on local server install
  61. Annoying/confusing WordPress memory limit exhausted
  62. Site title not showing. Please help me
  63. Create form which redirects to site in network?
  64. Redirect user role to a specific page on login in a multisite network?
  65. Getting an empty space in up sell items
  66. This occurs when I open admin or front on localhost
  67. Changable favicon
  68. Remove node from multisites?
  69. Add .php to end of all WordPress Pages (multisite)
  70. How to send logs to plugin owner for a plugin?
  71. Adding users to another blog
  72. Resource 404 error on multisite subdirectory install
  73. global $post inside plugin query messes up every new post page in wp-admin
  74. Importing demo data in Multisite
  75. Functions are causing errors
  76. WP multisite network plugin fails to see classes loaded with spl autoload
  77. WordPress causing all code to be displayed on line 1. Receiving multiple errors after cleaning cookies and cache
  78. Host does not allow remote connection, so how do I transfer data to my WordPress site?
  79. WordPress won’t display errors at all
  80. Custom PHP-coding in MU installs
  81. .htaccess on multisite and roots theme?
  82. WordPress MS wp-admin/includes/post.php error with shortcode generator
  83. Troubleshooting “loopback requests that take too long”
  84. Data inserted in database, but ajax calls error function
  85. Query Concatenation
  86. WP Debug enabled Undefined index error in a widget
  87. php 7.0 update to 7.1 and at least 7.2
  88. How to handle PHP parse errors?
  89. I need a button to appear when not loged in and another when logged in, I need help fixing code PLEASE!
  90. WordPress White Screen Error
  91. WPMU – How to echo only one URL
  92. Need help with Deprecated: Non-static error when update PHP 7.4 -> 8.1 with Dyad 2 theme
  93. kali php problem [closed]
  94. PHP warning: Undefined array key 2 in feed.php
  95. Getting invalid user ID error when creating a new user with wp_insert_user
  96. add_rewrite_rule image from /images/site2/favicon.ico to /favico.ico
  97. I can’t log into my website , it says “Error: Cookies are blocked due to unexpected output”
  98. Internal server error when enabling Multisite in WordPress
  99. Error when loading Dashboard
  100. WordPress @include( ‘template-config.php’ );