Proper way to use esc_html__ and esc_attr__ etc for escaping value for translation

You should use esc_html_e() instead of esc_attr_e() if you intend to escape your translation.

What is proper depends on your intend

Escaping attributes are well, for escaping attributes inside html tags like inline styles, datas, etc.

error code: 523