SQLSTATE[HY093]: Invalid parameter number: number of bound variables does not match number of tokens on line 102

You didn’t bind all your bindings here

$sql = "SELECT SQL_CALC_FOUND_ROWS *, UNIX_TIMESTAMP(publicationDate) AS publicationDate     FROM comments WHERE articleid = :art 
ORDER BY " . mysqli_escape_string($order) . " LIMIT :numRows";

$st = $conn->prepare( $sql );
$st->bindValue( ":art", $art, PDO::PARAM_INT );

You’ve declared a binding called :numRows but you never actually bind anything to it.

UPDATE 2019: I keep getting upvotes on this and that reminded me of another suggestion

Double quotes are string interpolation in PHP, so if you’re going to use variables in a double quotes string, it’s pointless to use the concat operator. On the flip side, single quotes are not string interpolation, so if you’ve only got like one variable at the end of a string it can make sense, or just use it for the whole string.

In fact, there’s a micro op available here since the interpreter doesn’t care about parsing the string for variables. The boost is nearly unnoticable and totally ignorable on a small scale. However, in a very large application, especially good old legacy monoliths, there can be a noticeable performance increase if strings are used like this. (and IMO, it’s easier to read anyway)

Leave a Comment