WordPress Title Tag Not Changing

The return function doesn’t require (). So you’d want your function to look like this:

function wpse_set_document_title_separator ( $sep) {
    return '-';
}
add_filter( 'document_title_separator', 'wpse_set_document_title_separator' );