Custom Post Custom Taxonomy Data Not Saving in Edit Screen

If you have a custom post type and a custom taxonomy assigned to it, you do not need to handle the saving of those terms yourself, WordPress already does this for you. So you can remove your taxonomy save code.

Also you should put your register_post_type and custom taxonomy registering code inside a function, and attach it to the init hook. It’s not safe to just declare them outright.