Endless loop with wp_insert_post and wp_update_post

It sure can be written in a more efficient way (untested):

$added = array();
global $wpdb;
foreach($uniques as $unique){
  $pagetitle = getTitle($unique);
  $new_post = array(
    'post_title' => $unique,
    'post_status' => 'publish',
    'post_type' => 'websites'
  );
  $pid = wp_insert_post($new_post);
  if ($pid) {
    $wpdb->query( $wpdb->prepare(
      "INSERT INTO $wpdb->postmeta (post_id, meta_key, meta_value) VALUES
       (%d, '%s', '%s'), (%d, '%s', '%s')",
       $pid, 'title', $pagetitle, $pid, 'url', $unique
    ) );
    $added[] = $pid;
  }
}
if ( ! empty($added) ) {
   $ids = implode(',', $added); 
   $wpdb->query("UPDATE $wpdb->posts SET `post_title` = `ID`, `post_name` = `ID` WHERE `ID` IN ($ids)");
}

With 600 urls this code runs 1200 queries less than your, but maybe is not enough…

Related Posts:

  1. save_post + insert_post = infinite loop
  2. Add Incrementing ID to each paragraph in the_content
  3. post__in – Placing content from a foreach loop inside of an array
  4. wp_insert_posts Fatal error: Maximum function nesting level of ‘100’ reached, aborting!
  5. In a foreach loop, how do I target the last item in the loop?
  6. Automatically insert php function into post $the_content
  7. How to iterate through database until it find a match
  8. Get all posts including sticky ones with get_posts(),setup_postdata(), and foreach loop?
  9. How to print out menu names in the foreach loop?
  10. Add class to last 3 posts in loop
  11. Output meta into arrays
  12. Need to add class to first element in a foreach loop
  13. Foreach displays from last to first
  14. Simple foreach loop help needed in wordpress “the loop”
  15. How to print redux gallery feilds id? [closed]
  16. How to check all items in a loop have post thumbnail?
  17. Get featured image outside the loop using foreach
  18. Why loop renders only last metabox from array? [closed]
  19. Foundation modal in wordpress php loop
  20. ACF field not appearing correctly in loop
  21. Eliminate duplicates in a foreach loop [closed]
  22. Wrap every 2 divs in row – for each loop [closed]
  23. ACF loops false value with repeater and checkbox
  24. How to place comments_template(); outside the loop?
  25. Insert/sticky specific post into Loop at specific location
  26. Style every four posts differently [duplicate]
  27. Return vs Echo Shortcode
  28. have_posts() return false but count says “3”
  29. next_posts_link not working in custom loop
  30. How to sort posts in archive loop
  31. Show top level comments ordered by number of replies
  32. Redirect Loop to Page, Can’t Find Origin, Can’t Remove [closed]
  33. wordpress change the loop order by dynamic value
  34. How to speed up a wordpress function with multiple loops?
  35. Post Format single-loop.php using get_template_part
  36. Use object in template part
  37. A loop with all articles with certain text strings in tags
  38. Prevent Headers from being sent
  39. How do I get row padding in a post feed?
  40. How can I create a legend (Key) like the one in the footer on WordPress StackExchange
  41. It is possible to encounter horrible bugs if I place a main loop that uses `query_posts` right above the main bbPress loop?
  42. Iterate through posts based on array of categories
  43. How to show “teaser” posts on blog / archive pages, otherwise full posts
  44. Make blog page show 10 on first page, 9 on every other page
  45. Alter query using pre_get_posts() if meta_key is present
  46. Next Posts Prev Posts for Standard post format only
  47. Alert Bar section within WP loop is displaying even though there are no posts
  48. Two loops on different pages do the same thing, but only one page works
  49. Posts active and expired in different loops
  50. Load wordpress content in other domain
  51. Genesis multiple category custom loop 404s after first page
  52. Shortcode in posts called by ajax is not working
  53. Using Javascript for Looped Content
  54. Making a query to the DB using same parameters of loop
  55. Variable not being passed into WordPress loop
  56. Exclude duplicated $sticky post from combined loop content
  57. Getting a custom field in the middle of a loop
  58. WP Loop. If featured image is a panorama (3:1 ratio) execute some code
  59. How to avoid duplicates when creating recent network posts
  60. Trying to get property of non-object in shortocde
  61. variable value disappears in a second loop
  62. How to Loop with the final result formatted differently?
  63. Tags on page (not post) returns nothing – why? Improved clarified question!
  64. Include future posts in tags and in search
  65. Display child page content of a specific parent on home page
  66. How to wrap every 3 posts in a div (and close the last div too) [closed]
  67. Dividing the loop to style post differently
  68. Show terms in archive page
  69. Problem in replacing the_content with the_excerpt()
  70. Loops for cat links not looping for wordpress site
  71. Sort posts according to a numeric value entered with ACF
  72. wp_get_attachment_url not fetching URL?
  73. get the value for ALT is we check to see if an actual ALT value is set, if not we use the caption and if no caption is set we use the title
  74. Display all categories including sub categories under a list ul
  75. How to get all multi-select user meta values and add them to an array?
  76. How to resolve a reload loop issue in the frontend when logged in to WordPress multi-site backend admin area
  77. Exclude Posts Using Meta Query and User Meta
  78. Excerpt isn’t working or am I missing something?
  79. Can I temporarily disable global $post?
  80. Shortcode for pulling specific Post Title outside loop when ID is passed in
  81. Show a list of user posts in the user admin page
  82. Efficient way of querying for a “fallback” post?
  83. Infinite Loop after Genesis Theme Upgrade
  84. Create a hierarchical loop at predefined markup requirements
  85. enumerating custom taxonomies?
  86. WordPress loop only displays 5 articles max?
  87. How to display thumbnail if post is assigned one otherwise not
  88. get_template_part() to render single page Theme
  89. Showing related posts (custom post type) outside of the loop
  90. Looping taxonomy in taxonomy?
  91. Post content not showing some content
  92. Paged homepage – requirements?
  93. Least Number of Loops to Create Custom Homepage?
  94. The Loop for my theme with static front page is not working
  95. WordPress loop: Display if posts exist
  96. How do I filter a custom post type loop by a field?
  97. Showing ads after posts in home page
  98. Create and publish a new post every Monday, listing the post titles and links to the posts published during the previous week
  99. Prevent duplicating specific column from database table
  100. wp_mail function not working in user query loop

Leave a Comment