Pull image from ACF field in a Custom Post Type

You need to define $landscape in the loop. You’re defining out so it is not part of your repeating portion.

Move it down just under the while line so it looks like this:

<?php 
$args = array( 'post_type' => 'products', 'posts_per_page' => 9 );
$the_query = new WP_Query( $args );


?>

<main class="site-content">
<div class="row">

    <?php if ( $the_query->have_posts() ) : ?>
        <?php while ( $the_query->have_posts() ) : $the_query->the_post(); ?>

            $landscape = get_field('main_photo_landscape');

            <article class="col-12 col-md-6 col-lg-4 product">
                <a href="https://wordpress.stackexchange.com/questions/363095/<?php the_permalink(); ?>" title="<?php the_title_attribute(); ?>">
                    <div class="featured-img" style="background: url('<?php echo $landscape['sizes']['large']; ?>') center center no-repeat; background-size: auto 100%"></div>
                    <h1 class="title"><?php the_title(); ?></h1>
                    <button class="btn">More Details</button>
                </a>
            </article>

        <?php endwhile; ?>

        <?php the_posts_navigation(); ?>

    <?php endif; ?>

</div>

Notice I removed , $post->ID as well.